Allow for DDL and unsupported statements as a query #2377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like `-- name: InsertMulti :exec multiple` and `-- name: Select :many key=group_id` issue sqlc-dev#2353
By adding 'no-inference' to your query comment, sqlc won't try to understand your query. (The dolphin/postgresql parser still need to understand your syntax.) This means that params and output columns don't work, but you can run any query you want.
|
Sorry for the delay @Jille. I think we shouldn't introduce new query comment syntax, but the idea here is good. I think what we should do is allow CREATE TABLE foo (val text not null);
-- name: CreateTempTable :exec
CREATE TEMPORARY TABLE bar (LIKE foo); |
|
@Jille the new database-backed analyzer actually handles the test case in my last comment. |
andrewmbenton
added a commit
that referenced
this pull request
Dec 19, 2023
…odes This allows users to run generate on any parseable query, even when sqlc doesn't understand it. Closes #2377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding 'no-inference' to your query comment, sqlc won't try to understand your query. (The dolphin/postgresql/sqlite parser still need to understand your syntax.) This means that params and output columns don't work, but you can run any query you want.