feat(analyzer): Return zero values when encountering unexpected ast nodes (#3069)

This allows users to run generate on any parseable query, even
when sqlc doesn't understand it.

Closes #2377

Author: andrewmbenton

internal/compiler/analyze.go

@@ -135,10 +135,6 @@ func (c *Compiler) _analyzeQuery(raw *ast.RawStmt, query string, failfast bool)
 
 	var table *ast.TableName
 	switch n := raw.Stmt.(type) {
-	case *ast.CallStmt:
-	case *ast.SelectStmt:
-	case *ast.DeleteStmt:
-	case *ast.DoStmt:
 	case *ast.InsertStmt:
 		if err := check(validate.InsertStmt(n)); err != nil {
 			return nil, err
@@ -148,15 +144,6 @@ func (c *Compiler) _analyzeQuery(raw *ast.RawStmt, query string, failfast bool)
 		if err := check(err); err != nil {
 			return nil, err
 		}
-	case *ast.ListenStmt:
-	case *ast.NotifyStmt:
-	case *ast.TruncateStmt:
-	case *ast.UpdateStmt:
-	case *ast.RefreshMatViewStmt:
-	default:
-		if err := check(ErrUnsupportedStatementType); err != nil {
-			return nil, err
-		}
 	}
 
 	if err := check(validate.FuncCall(c.catalog, c.combo, raw)); err != nil {

internal/compiler/compile.go

@@ -79,9 +79,6 @@ func (c *Compiler) parseQueries(o opts.Parser) (*Result, error) {
 		}
 		for _, stmt := range stmts {
 			query, err := c.parseQuery(stmt.Raw, src, o)
-			if err == ErrUnsupportedStatementType {
-				continue
-			}
 			if err != nil {
 				var e *sqlerr.Error
 				loc := stmt.Raw.Pos()
@@ -95,6 +92,10 @@ func (c *Compiler) parseQueries(o opts.Parser) (*Result, error) {
 				}
 				continue
 			}
+			if query == nil {
+				continue
+			}
+			query.Metadata.Filename = filepath.Base(filename)
 			queryName := query.Metadata.Name
 			if queryName != "" {
 				if _, exists := set[queryName]; exists {
@@ -103,10 +104,7 @@ func (c *Compiler) parseQueries(o opts.Parser) (*Result, error) {
 				}
 				set[queryName] = struct{}{}
 			}
-			query.Metadata.Filename = filepath.Base(filename)
-			if query != nil {
-				q = append(q, query)
-			}
+			q = append(q, query)
 		}
 	}
 	if len(merr.Errs()) > 0 {

internal/compiler/output_columns.go

@@ -57,7 +57,7 @@ func (c *Compiler) outputColumns(qc *QueryCatalog, node ast.Node) ([]*Column, er
 		return nil, err
 	}
 
-	var targets *ast.List
+	targets := &ast.List{}
 	switch n := node.(type) {
 	case *ast.DeleteStmt:
 		targets = n.ReturningList
@@ -114,16 +114,8 @@ func (c *Compiler) outputColumns(qc *QueryCatalog, node ast.Node) ([]*Column, er
 		if isUnion {
 			return c.outputColumns(qc, n.Larg)
 		}
-	case *ast.DoStmt:
-		targets = &ast.List{}
-	case *ast.CallStmt:
-		targets = &ast.List{}
-	case *ast.TruncateStmt, *ast.RefreshMatViewStmt, *ast.NotifyStmt, *ast.ListenStmt:
-		targets = &ast.List{}
 	case *ast.UpdateStmt:
 		targets = n.ReturningList
-	default:
-		return nil, fmt.Errorf("outputColumns: unsupported node type: %T", n)
 	}
 
 	var cols []*Column
@@ -487,7 +479,7 @@ func (r *tableVisitor) Visit(n ast.Node) astutils.Visitor {
 // Return an error if a table is referenced twice
 // Return an error if an unknown column is referenced
 func (c *Compiler) sourceTables(qc *QueryCatalog, node ast.Node) ([]*Table, error) {
-	var list *ast.List
+	list := &ast.List{}
 	switch n := node.(type) {
 	case *ast.DeleteStmt:
 		list = n.Relations
@@ -514,14 +506,6 @@ func (c *Compiler) sourceTables(qc *QueryCatalog, node ast.Node) ([]*Table, erro
 		astutils.Walk(&tv, n.FromClause)
 		astutils.Walk(&tv, n.Relations)
 		list = &tv.list
-	case *ast.DoStmt:
-		list = &ast.List{}
-	case *ast.CallStmt:
-		list = &ast.List{}
-	case *ast.NotifyStmt, *ast.ListenStmt:
-		list = &ast.List{}
-	default:
-		return nil, fmt.Errorf("sourceTables: unsupported node type: %T", n)
 	}
 
 	var tables []*Table

internal/compiler/parse.go

@@ -15,8 +15,6 @@ import (
 	"github.com/sqlc-dev/sqlc/internal/sql/validate"
 )
 
-var ErrUnsupportedStatementType = errors.New("parseQuery: unsupported statement type")
-
 func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query, error) {
 	ctx := context.Background()
 

internal/endtoend/testdata/exec_create_table/mysql/db/db.go

@@ -0,0 +1,2 @@
+-- name: CreateTable :exec
+CREATE TABLE test (id INTEGER NOT NULL);

internal/endtoend/testdata/exec_create_table/mysql/db/models.go

@@ -0,0 +1,8 @@
+version: 2
+sql:
+- queries: mysql.query.sql
+  schema: mysql.schema.sql
+  engine: mysql
+  gen:
+    go:
+      out: db

internal/endtoend/testdata/exec_create_table/mysql/db/mysql.query.sql.go

@@ -0,0 +1,2 @@
+-- name: CreateTable :exec
+CREATE TABLE test (id INTEGER NOT NULL);

internal/endtoend/testdata/exec_create_table/mysql/mysql.query.sql

@@ -0,0 +1,9 @@
+version: 2
+sql:
+- queries: postgresql.query.sql
+  schema: postgresql.schema.sql
+  engine: postgresql
+  gen:
+    go:
+      out: db
+

internal/endtoend/testdata/exec_create_table/mysql/mysql.schema.sql

@@ -0,0 +1,8 @@
+version: 2
+sql:
+- queries: sqlite.query.sql
+  schema: sqlite.schema.sql
+  engine: sqlite
+  gen:
+    go:
+      out: db

internal/endtoend/testdata/exec_create_table/mysql/sqlc.yaml

@@ -0,0 +1,2 @@
+-- name: CreateTable :exec
+CREATE TABLE test (id INTEGER NOT NULL);

internal/endtoend/testdata/exec_create_table/postgresql/db/db.go

@@ -1,9 +1,3 @@
-CREATE TABLE authors (
-          id   BIGSERIAL PRIMARY KEY,
-          name text      NOT NULL,
-          bio  text
-);
-
 -- name: GetAuthor :one
 SELECT * FROM authors
 WHERE id = $1 LIMIT 1;

internal/endtoend/testdata/exec_create_table/postgresql/db/models.go

@@ -1,6 +1,6 @@
 version: 2
 sql:
-  - schema: "query.sql"
+  - schema: "schema.sql"
     queries: "query.sql"
     engine: "postgresql"
     gen: