Skip to content

GH-4008: Add leader and participants support #4011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

GH-4008: Add leader and participants support #4011

merged 1 commit into from
Feb 7, 2023

Conversation

ivan-zaitsev
Copy link
Contributor

Fixes #4008

  • change return type of LeaderInitiator.getContext() from Context to CuratorContext
  • add getLeader() method to CuratorContext
  • add getParticipants() to CuratorContext

@pivotal-cla
Copy link

@ivan909020 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ivan909020 Thank you for signing the Contributor License Agreement!

@ivan-zaitsev ivan-zaitsev reopened this Feb 6, 2023
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see code style of the project: https://github.com/spring-projects/spring-integration/wiki/Spring-Integration-Framework-Code-Style.

You need to reconfigure your IDE for our editor config, so imports are ordered according to our Checkstyle requirements.

The rest looks good to me.
Will double check locally tomorrow and merge.

👍

Fixes #4008

* change return type of LeaderInitiator.getContext() from Context to CuratorContext
* add getLeader() method to CuratorContext
* add getParticipants() method to CuratorContext
@ivan-zaitsev
Copy link
Contributor Author

@artembilan Fixed code style

@artembilan artembilan merged commit e6d0a4f into spring-projects:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to retrieve current leader id from LeaderInitiator
3 participants