Impossible to retrieve current leader id from LeaderInitiator

[ivan-zaitsev]

Hello,

Currently it is impossible to retrieve current leader id from LeaderInitiator because LeaderSelector field is private and has no getter.

It would be really helpful to have this functionality for cases when we need to understand what node is a leader.
I think it is better to add getter for LeaderSelector instead of delegate method for current leader. It could cover cases when we need for example retrieve list of all participants.

[garyrussell]

... it is impossible...

Leadership changes are published as application events; add an @EventListener method (or ApplicationListener bean) to consume OnGrantedEvent, OnRevokedEvent.

[artembilan]

I think it won't hurt to expose getLeaderSelector() on the LeaderInitiator.
Feel free to contribute such a fix: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc !

[ivan-zaitsev]

... it is impossible...

Leadership changes are published as application events; add an @EventListener method (or ApplicationListener bean) to consume OnGrantedEvent, OnRevokedEvent.

It only publishes for current node if that node is a leader, but when different node is a leader it won't be published for other nodes, therefore we cannot check which node is a leader from non-leader node

[ivan-zaitsev]

I think it won't hurt to expose getLeaderSelector() on the LeaderInitiator. Feel free to contribute such a fix: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc !

Ok, thanks, will do 🙂

[ivan-zaitsev]

I think it won't hurt to expose getLeaderSelector() on the LeaderInitiator. Feel free to contribute such a fix: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc !

Possibly it will allow to call any method in LeaderInitiator even close() method. Calling close() method will not change running internal state of LeaderInitiator and Lifecycle.isRunning() will always return true, even when LeaderInitiator is in closed state.

[artembilan]

Why would one do that?
I would suggest then to expose only read-only operations of the LeaderSelector.
It is not OK to mutate that object since its lifecycle is controlled by the LeaderInitiator.