Fix constant name lookup for null name prefix #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though javadoc fo Constants.toCode specifies that null value for namePrefix parameter is allowed, before this change pasing null would throw NullPointerException. This change fixes constant name lookup for null name prefix as if empty name prefix was used so that all names match, and lookup is performed only by constant value. This way of handling null value for name prefix is consistent with the rest of Constants class API. Issue: SPR-8278
cbeams
added a commit
that referenced
this pull request
May 17, 2012
* SPR-8278: Fix compiler warnings in Constants/ConstantsTests Allow null params as advertised in Constants#toCode*
|
Thanks, Stevo, this is merged. Take a look at 6ffb043; you'll see I applied your fix to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though javadoc fo Constants.toCode specifies that null value for
namePrefix parameter is allowed, before this change pasing null would
throw NullPointerException.
This change fixes constant name lookup for null name prefix as if empty
name prefix was used so that all names match, and lookup is performed
only by constant value. This way of handling null value for name prefix
is consistent with the rest of Constants class API.
Issue: SPR-8278
I have signed and agree to the terms in the SpringSource Individual Contributor License Agreement.