Constants.toCode throws NPE when namePrefix is null [SPR-8278]

[spring-projects-issues]

Vasily Ivanov opened SPR-8278 and commented

org.springframework.core.Constants.toCode() javadoc says:

"namePrefix prefix of the constant names to search (may be null)"

However if null namePrefix is passed in then toCode throws NPE on startsWith check.

---

Affects: 3.0.4

Referenced from: commits 0e8f5d8, 6ffb043

1 votes, 2 watchers

[spring-projects-issues]

Stevo Slavić commented

Created pull request with fix for this issue.

[spring-projects-issues]

Chris Beams commented

Thanks, Stevo. Will take a look.

[spring-projects-issues]

Chris Beams commented

Thanks, Vasily and Stevo!

commit 6ffb0436fa55fb73048a5a9133a98e122e490119
Author: Stevo Slavic <sslavic@gmail.com>
Date:   Tue Mar 13 19:55:12 2012 +0100

    Allow null params as advertised in Constants#toCode*
    
    Even though the Javadoc for Constants#toCode and #toCodeForSuffix
    specifies that a null value for the 'namePrefix' and 'nameSuffix'
    parameters are respectively allowed, before this change passing a null
    to either would result in a NullPointerException.
    
    This change fixes constant name lookup for null values of these params
    as if an empty string had been passed instead. This way of handling a
    null value is consistent with the rest of Constants class API.
    
    Issue: SPR-8278