DATAJDBC-264 - Fix insert query for empty nonIdColumnNames #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunnyone Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
schauder
changed the title
|
@sunnyone could you please provide your name written with Latin characters, so I include it in an |
|
@sunnyone Thank you for signing the Contributor License Agreement! |
|
My name is Yoichi Imai. Thanks. |
schauder
pushed a commit
that referenced
this pull request
Sep 18, 2018
When an entity consists only of it's id column, the value list contained a single `:`. This commit fixes this. Original pull request: #88.
schauder
added a commit
that referenced
this pull request
Sep 18, 2018
Added a test. Added an author tag. Minor formatting. Original pull request: #88.
|
Thanks, that is polished and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlGenerator.createInsertSql fails to generate sql when nonIdColumnNames is empty.
This method outputs like this:
This pull request fixes this behaivor. It uses the way of createUpdateSql instead of Collectors.joining(delimiter, prefix, suffix).