Skip to content

Commit 8434f6e

Browse files
sunnyoneschauder
authored andcommitted
DATAJDBC-264 - Fix insert statement for empty parameter list.
When an entity consists only of it's id column, the value list contained a single `:`. This commit fixes this. Original pull request: #88.
1 parent 08ee846 commit 8434f6e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/java/org/springframework/data/jdbc/core/SqlGenerator.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,9 @@ private String createInsertSql(Set<String> additionalColumns) {
260260
columnNamesForInsert.addAll(additionalColumns);
261261

262262
String tableColumns = String.join(", ", columnNamesForInsert);
263-
String parameterNames = columnNamesForInsert.stream().collect(Collectors.joining(", :", ":", ""));
263+
String parameterNames = columnNamesForInsert.stream()//
264+
.map(n -> String.format(":%s", n))//
265+
.collect(Collectors.joining(", "));
264266

265267
return String.format(insertTemplate, entity.getTableName(), tableColumns, parameterNames);
266268
}

0 commit comments

Comments
 (0)