DATAREDIS-286 - Avoid overflow in JedisConnection#expire / #pexpire. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
thomasdarimont
pushed a commit
that referenced
this pull request
Mar 21, 2014
Workaround Jedis issue redis/jedis#575. We now delegate calls to expire(...) to pExpire(...) in case the seconds parameter is > than Integer.MAX_VALUE. Original pull request: #52.
|
Thanks for making the fix so quickly! It makes sense and looks good to me. |
Workaround Jedis issue redis/jedis#575. We now delegate calls to expire(...) to pExpireAt(...) in case the seconds parameter is > than Integer.MAX_VALUE. We query the server time to compute the new expiration date. Original pull request: #52.
Added unit test to issue as separate commit.
thomasdarimont
pushed a commit
that referenced
this pull request
Mar 24, 2014
Workaround Jedis issue redis/jedis#575. We now delegate calls to expire(...) to pExpireAt(...) in case the seconds parameter is > than Integer.MAX_VALUE. We query the server time to compute the new expiration date. Original pull request: #52.
thomasdarimont
pushed a commit
that referenced
this pull request
Mar 24, 2014
Workaround Jedis issue redis/jedis#575. We now delegate calls to expire(...) to pExpireAt(...) in case the seconds parameter is > than Integer.MAX_VALUE. We query the server time to compute the new expiration date. Original pull request: #52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround Jedis issue redis/jedis#575.
We now delegate calls to expire(...) to pExpire(...) in case the seconds parameter is > than Integer.MAX_VALUE.