RedisTemplate.expire() overflow [DATAREDIS-286]

[spring-projects-issues]

Eric Wu opened DATAREDIS-286 and commented

The method

RedisTemplate<K, V>.expire(K key, long timeout, TimeUnit unit)

won't work for a timeout of 200 days.

I got this bug after upgrading Spring Data Redis from 1.1.1.RELEASE to 1.2.0.RELEASE.

The root cause is that Jedis is having an issue with the pexpire() method (See Jedis Issue 575, 576, and 577). Basically that method takes an integer as the timeout which easily overflows.

The work-around is to use Jedis's pexpireAt() instead, which takes a long integer.

My environment:

1. Spring Data Redis 1.2.0-RELEASE
2. Jedis 2.4.1
3. Redis 2.8.6

---

Affects: 1.2.0

Issue Links:

• DATAREDIS-564 Invoking JedisConnection.expire during transaction/pipelining can cause NPE

Referenced from: pull request #52

Backported to: 1.2.1

[spring-projects-issues]

Thomas Darimont commented

Hello Eric,

thanks for reporting this :)

As a workaround we would suggest to extend {JedisConnection} and delegate expire to pexpire when the passed (long) seconds exceeds the int bounds.

In order to return your custom connection (that probably only wraps the given {JedisConnection} and overwrites just expire) you have to overwrite
{org.springframework.data.redis.connection.jedis.JedisConnectionFactory.postProcessConnection(JedisConnection)} and return your custom connection.

We're currently discussing how we should fix it.

Cheers,
Thomas

[spring-projects-issues]

Thomas Darimont commented

I implemented the suggested workaround - please revise

[spring-projects-issues]

Thomas Darimont commented

@Eric would you mind having a look at the PR above?

Cheers,
Thomas

[spring-projects-issues]

Eric Wu commented

I just left a comment on GitHub. It looks good. Thanks for making the fix!

[spring-projects-issues]

Christoph Strobl commented

Merged into master and back ported to 1.2.x