DATAREDIS-548 - Release connection after command execution in read-only transactions. #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y transactions. Prepare issue branch.
…ly transactions. Previously, RedisConnection's were bound as transactional resource when used in the scope of a @transactional(readOnly = true) method but not released on transaction completion. This was, because connections are not registered with a transaction synchronizer. We now unbind and release the connection from the transaction resources after a Redis command is invoked. Redis read operations return always null while using RedisTemplate in a transaction so Redis read transactions are not useful.
christophstrobl
pushed a commit
that referenced
this pull request
Aug 30, 2016
…ly transactions. We now unbind and release the connection from the transaction resources after a Redis command is invoked. Redis read operations return always null while using RedisTemplate in a transaction so Redis read transactions are not useful. Previously, RedisConnection's were bound as transactional resource when used in the scope of a @transactional(readOnly = true) method but not released on transaction completion. This was, because connections are not registered with a transaction synchronizer. Original Pull Request: #214
christophstrobl
added a commit
that referenced
this pull request
Aug 30, 2016
Added connection starvation test for operations during readonly transaction. Original Pull Request: #214
christophstrobl
pushed a commit
that referenced
this pull request
Aug 30, 2016
…ly transactions. We now unbind and release the connection from the transaction resources after a Redis command is invoked. Redis read operations return always null while using RedisTemplate in a transaction so Redis read transactions are not useful. Previously, RedisConnection's were bound as transactional resource when used in the scope of a @transactional(readOnly = true) method but not released on transaction completion. This was, because connections are not registered with a transaction synchronizer. Original Pull Request: #214
christophstrobl
added a commit
that referenced
this pull request
Aug 30, 2016
Added connection starvation test for operations during readonly transaction. Original Pull Request: #214
christophstrobl
pushed a commit
that referenced
this pull request
Aug 30, 2016
…ly transactions. We now unbind and release the connection from the transaction resources after a Redis command is invoked. Redis read operations return always null while using RedisTemplate in a transaction so Redis read transactions are not useful. Previously, RedisConnection's were bound as transactional resource when used in the scope of a @transactional(readOnly = true) method but not released on transaction completion. This was, because connections are not registered with a transaction synchronizer. Original Pull Request: #214
christophstrobl
added a commit
that referenced
this pull request
Aug 30, 2016
Added connection starvation test for operations during readonly transaction. Original Pull Request: #214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, RedisConnection's were bound as transactional resource when used in the scope of a
@Transactional(readOnly = true)method but not released on transaction completion. This was, because connections are not registered with a transaction synchronizer.We now unbind and release the connection from the transaction resources after a Redis command is invoked. Redis read operations return always null while using RedisTemplate in a transaction so Redis read transactions are not useful.
Related ticket: DATAREDIS-548
Related PR: #209