RedisTemplate with disabled transaction support can't use multi/exec in readOnly Transaction [DATAREDIS-1007]

[spring-projects-issues]

alonWang opened DATAREDIS-1007 and commented

I believe this pr cause this, #214

to solve it,just need to modify here

RedisConnectionUtils.releaseConnection()

// when redis "transactional" & enableTranactionSupport & readOnly,then release connection.
if (isConnectionTransactional(conn, factory)&& enableTranactionSupport && TransactionSynchronizationManager.isCurrentTransactionReadOnly()) {
            unbindConnection(factory);
        } else if (!isConnectionTransactional(conn, factory)) {
            if (log.isDebugEnabled()) {
                log.debug("Closing Redis Connection");
            }
            conn.close();
        }

---

Affects: 2.2 RC1 (Moore), 1.8.22 (Ingalls SR22), 2.1.9 (Lovelace SR9)

[spring-projects-issues]

alonWang commented

 

demo

@Transactional(propagation = Propagation.SUPPORTS, readOnly = true, rollbackFor = Exception.class)
public mixTransaction(){
//... some jpa read operations
//redisTemplate.enableTransactionSupport is default false. using jedis as Redis Connection.
List result=redisTemplate.execute(new SessionCallback<List>() {
				@SuppressWarnings({ "unchecked" })
				@Override
				public List execute(RedisOperations operations)
								throws DataAccessException {
						operations.watch("123");
                                                // .. check operations
						operations.multi()
						//.. some set operations
						return operations.exec()	
				}
}

 

[spring-projects-issues]

Mark Paluch commented

We could store that the Template's transaction support was disabled when creating RedisConnectionHolder and evaluate this setting in RedisConnectionUtils.releaseConnection(…)

[spring-projects-issues]

alonWang commented

spring-data-redis 2.1.9 have solved this

[spring-projects-issues]

Mark Paluch commented

Thanks for checking. Closing this ticket