-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DATAMONGO-1393 fixed validation for Lazy Proxies #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks @Puel - can you please add your CLA number as a comment to this PR or DATAMONGO-1393 so we can take it from here. |
…xies. ValidatingMongoEventListener checks now whether the validated object is a lazy-loading proxy. In such a case the proxy is unwrapped and the validation is performed with the underlying target object. Original pull request: #350. CLA: 168220160322083905 (Paul Sterl)
Inline repositories into test. Apply Spring Data formatting rules. Remove final keyword from local variables. Remove unused XML namespace declarations. Original pull request: #350.
…xies. ValidatingMongoEventListener checks now whether the validated object is a lazy-loading proxy. In such a case the proxy is unwrapped and the validation is performed with the underlying target object. Original pull request: #350. CLA: 168220160322083905 (Paul Sterl)
Inline repositories into test. Apply Spring Data formatting rules. Remove final keyword from local variables. Remove unused XML namespace declarations. Original pull request: #350.
…xies. ValidatingMongoEventListener checks now whether the validated object is a lazy-loading proxy. In such a case the proxy is unwrapped and the validation is performed with the underlying target object. Original pull request: #350. CLA: 168220160322083905 (Paul Sterl)
Inline repositories into test. Apply Spring Data formatting rules. Remove final keyword from local variables. Remove unused XML namespace declarations. Original pull request: #350.
Hi @Puel, I started polishing your contribution until we realized alternative approaches to the issue and the consequences this change draws. I updated and commented the ticket DATAMONGO-1393. |
@sterlp Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@sterlp Thank you for signing the Contributor License Agreement! |
Paul Sterl added a comment - 04/Apr/16 10:19 AM |
We decided to not implement this functionality as we don't want to leak Proxy-awareness into unrelated support classes. |
https://jira.spring.io/browse/DATAMONGO-1393
Fixing this issue I found another I will create a separate ticket for.
I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.