Skip to content

DATAMONGO-1393 fixed validation for Lazy Proxies #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

sterlp
Copy link

@sterlp sterlp commented Mar 22, 2016

https://jira.spring.io/browse/DATAMONGO-1393

Fixing this issue I found another I will create a separate ticket for.

I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.

@christophstrobl
Copy link
Member

thanks @Puel - can you please add your CLA number as a comment to this PR or DATAMONGO-1393 so we can take it from here.

mp911de pushed a commit that referenced this pull request Jun 2, 2016
…xies.

ValidatingMongoEventListener checks now whether the validated object is a lazy-loading proxy. In such a case the proxy is unwrapped and the validation is performed with the underlying target object.

Original pull request: #350.
CLA: 168220160322083905 (Paul Sterl)
mp911de added a commit that referenced this pull request Jun 2, 2016
Inline repositories into test. Apply Spring Data formatting rules. Remove final keyword from local variables. Remove unused XML namespace declarations.

Original pull request: #350.
mp911de pushed a commit that referenced this pull request Jun 2, 2016
…xies.

ValidatingMongoEventListener checks now whether the validated object is a lazy-loading proxy. In such a case the proxy is unwrapped and the validation is performed with the underlying target object.

Original pull request: #350.
CLA: 168220160322083905 (Paul Sterl)
mp911de added a commit that referenced this pull request Jun 2, 2016
Inline repositories into test. Apply Spring Data formatting rules. Remove final keyword from local variables. Remove unused XML namespace declarations.

Original pull request: #350.
mp911de pushed a commit that referenced this pull request Jun 2, 2016
…xies.

ValidatingMongoEventListener checks now whether the validated object is a lazy-loading proxy. In such a case the proxy is unwrapped and the validation is performed with the underlying target object.

Original pull request: #350.
CLA: 168220160322083905 (Paul Sterl)
mp911de added a commit that referenced this pull request Jun 2, 2016
Inline repositories into test. Apply Spring Data formatting rules. Remove final keyword from local variables. Remove unused XML namespace declarations.

Original pull request: #350.
@mp911de
Copy link
Member

mp911de commented Jun 3, 2016

Hi @Puel,

I started polishing your contribution until we realized alternative approaches to the issue and the consequences this change draws. I updated and commented the ticket DATAMONGO-1393.

@pivotal-issuemaster
Copy link

@sterlp Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@sterlp Thank you for signing the Contributor License Agreement!

@sterlp
Copy link
Author

sterlp commented May 23, 2018

Paul Sterl added a comment - 04/Apr/16 10:19 AM
Confirmation number is 168220160322083905
https://jira.spring.io/browse/DATAMONGO-1393?focusedCommentId=128420&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-128420

@mp911de
Copy link
Member

mp911de commented Jan 9, 2020

We decided to not implement this functionality as we don't want to leak Proxy-awareness into unrelated support classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants