ValidatingMongoEventListener doesn't work with LazyLoadingProxy [DATAMONGO-1393]

[spring-projects-issues]

Paul Sterl opened DATAMONGO-1393 and commented

Basically the following line is missing in the ValidatingMongoEventListener:

final Object target = obj instanceof LazyLoadingProxy ? ((LazyLoadingProxy) obj).getTarget() : obj;

as otherwise the validation is done on the proxy object and so always fails.

Details:

http://sterl.org/2016/03/spring-data-mongodb-jsr-validation/

---

Affects: 1.8.4 (Gosling SR4)

Reference URL: http://sterl.org/2016/03/spring-data-mongodb-jsr-validation/

Referenced from: pull request #350

[spring-projects-issues]

Paul Sterl commented

I have signed and agree to the terms of the Spring Individual Contributor
License Agreement

[spring-projects-issues]

Paul Sterl commented

Confirmation number is 168220160322083905

[spring-projects-issues]

Paul Sterl commented

Any update on this issue?

[spring-projects-issues]

Mark Paluch commented

Hi Paul Sterl

the preferred solution to this issue is annotating the accessor methods as the underlying proxy is not initialized and the fields are null. LazyLoadingProxy is used in very few components within Spring Data MongoDB. We'd like to avoid spreading the knowledge of lazy-loading proxies across various components

[spring-projects-issues]

Paul Sterl commented

Hello Mark,

maybe I didn't get your way of solving it. First of all I didn't understand why hibernate was involved. As it isn't a hibernate issue at all. It is the Mongo bridge code which is buggy. I agree that I wouldn't spread the Mongo Proxy Logic into Hibernate. As it has nothing to do with either hibernate or JPA.

I adjusted the Mongo +ValidatingMongoEventListener+, in respect to what I found already in +MappingMongoConverter+, which of course faces the same issue otherwise during the save operation.

Or let me rephrase it: The persist logic in Spring Mongo Data does the things the way like I think the Spring Mongo Validation should do too.

Does this make any sense?

Cheers

Paul

[spring-projects-issues]

Mark Paluch commented

Hibernate Validator is the involved as implementation for JSR 303. Hibernate Validator uses the annotated member instead of property accessors even if property accessors are defined.
Spring Data MongoDB does not perform bean validation on its own but invokes the validation with the given object.

The preferred solution is to annotate your getter/setters:

class Address {
 
 String street;
 
 @NonNull String getStreet() {
   return street;
 }
}

instead of

class Address {
 
 @NonNull String street;
 
 …
}

[spring-projects-issues]

Mark Paluch commented

We decided to not implement this functionality as we don't want to leak Proxy-awareness into unrelated support classes