DATAMONGO-1287 - Fix double fetching for lazy DbRef used in ctor. #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…azy DbRef to change them afterwards by proxies. Prepare issue branch.
We now check properties for their usage as ctor arguments, that might already have been resolved, before setting the actual value. This prevents turning already eagerly fetched DBRefs back into LazyLoadingProxies. Relates to original PR #322.
odrotbohm
added a commit
that referenced
this pull request
Nov 23, 2015
… arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322.
odrotbohm
added a commit
that referenced
this pull request
Nov 23, 2015
… arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322.
odrotbohm
added a commit
that referenced
this pull request
Nov 23, 2015
… arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check properties for their usage as ctor arguments, that might already have been resolved, before setting the actual value. This prevents turning already eagerly fetched DBRefs back into
LazyLoadingProxies.Resolves part covered in #322 by adding dedicated tests and decoupling from DATAMONGO-1271.