DATAMONGO-1271 Provide read lifecycle events when loading DBRefs #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b27368.
|
BTW my CLA code is 121620150519031801 |
christophstrobl
added a commit
that referenced
this pull request
Nov 19, 2015
We now check properties for their usage as ctor arguments, that might already have been resolved, before setting the actual value. This prevents turning already eagerly fetched DBRefs back into LazyLoadingProxies. Relates to original PR #322.
|
@yacota I've created #335 to separate DATAMONGO-1287 (the issue with lazy dbref values in ctor) from DATAMONGO-1271. Once that's solved I'll take care about this one here. Thanks already! |
yacota
changed the title
yacota
changed the title
odrotbohm
added a commit
that referenced
this pull request
Nov 23, 2015
… arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322.
odrotbohm
added a commit
that referenced
this pull request
Nov 23, 2015
… arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322.
odrotbohm
added a commit
that referenced
this pull request
Nov 23, 2015
… arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322.
yacota
changed the title
|
@christophstrobl DATAMONGO-1287 was closed a long time ago but DATAMONGO-1271 is still "work in progress". Can I do anything to speed up things?, maybe this feature is finally discarded? ... I would really like to have feedback about it (I know all the team is pretty busy working on new things) |
christophstrobl
pushed a commit
that referenced
this pull request
May 24, 2016
We now publish livecycle events when loading DBRefs. Original Pull Request: #322 CLA: 121620150519031801 (Jordi Llach Fernandez)
christophstrobl
added a commit
that referenced
this pull request
May 24, 2016
Removed non Java 6 language features, reworked and added a few tests. Original Pull Request: #322
|
While checking the original PR you've seen that in the original PR I assumed that lazy DBRef when used in constructor should be skipped(non resolved), as we discussed in https://jira.spring.io/browse/DATAMONGO-1287 that is not the desired behaviour and resolving them eagerly was preferred. |
christophstrobl
added a commit
that referenced
this pull request
May 24, 2016
Removed non Java 6 language features, reworked and added a few tests. Original Pull Request: #322
christophstrobl
pushed a commit
that referenced
this pull request
May 25, 2016
We now publish livecycle events when loading DBRefs. Original Pull Request: #322 CLA: 121620150519031801 (Jordi Llach Fernandez)
christophstrobl
added a commit
that referenced
this pull request
May 25, 2016
Removed non Java 6 language features, reworked and added a few tests. Original Pull Request: #322
|
@christophstrobl to me it's 👍 |
christophstrobl
pushed a commit
that referenced
this pull request
May 27, 2016
We now publish livecycle events when loading DBRefs. Original Pull Request: #322 CLA: 121620150519031801 (Jordi Llach Fernandez)
christophstrobl
added a commit
that referenced
this pull request
May 27, 2016
Removed non Java 6 language features, reworked and added a few tests. Original Pull Request: #322
|
You're welcome @christophstrobl |
christophstrobl
pushed a commit
that referenced
this pull request
May 27, 2016
We now publish livecycle events when loading DBRefs. Original Pull Request: #322 CLA: 121620150519031801 (Jordi Llach Fernandez)
christophstrobl
added a commit
that referenced
this pull request
May 27, 2016
Removed non Java 6 language features, reworked and added a few tests. Original Pull Request: #322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR was for 1271 initially but then found 1287