DATAKV-115 - Make derived finder execution thread-safe. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
We now make sure seprate SpelExpression and EvaluationContext for each and every derived finder execution to assert the expression context cannot be accidentally overridden.
christophstrobl
force-pushed
the
issue/DATAKV-115
branch
from
7b66d16 to
188ecc3
Compare
odrotbohm
pushed a commit
that referenced
this pull request
Feb 9, 2016
We now make sure separate SpelExpression and EvaluationContext for each and every derived finder execution to assert the expression context cannot be accidentally overridden. Original pull request: #16.
odrotbohm
added a commit
that referenced
this pull request
Feb 9, 2016
Introduced dedicated constructor on SpelCriteria to default the EvaluationContext to StandardEvaluationContext. Switched to ternary if in KeyValuePartTreeQuery for both application of Pageable and Sort. Tweaked unit test to actually compile in Eclipse. Original pull request: #16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now make sure separate
SpelExpressionandEvaluationContextfor each and every derived finder execution to assert the context cannot be accidentally overridden.