Executing query methods on repositories is not thread-safe [DATAKV-115]

[spring-projects-issues]

Shu Yu opened DATAKV-115 and commented

I am using Spring data key value for a web application. Calls to a repository's findByXXX fail randomly, causing an exception.

I have attached the test case that can reproduce the problem.

I think that KeyValuePartTreeQuery is reusing a SpelExpression object, causing failing in SpelQueryEngine.filterMatchingRange() because the expression evaluation context in one thread can be changed by another thread

---

Affects: 1.0 GA (Gosling)

Attachments:

• mavenProject.ZIP (3.36 kB)

Referenced from: pull request #16

[spring-projects-issues]

Christoph Strobl commented

Thanks Shu Yu for bringing that issue up - good catch!

[spring-projects-issues]

Oliver Drotbohm commented

I don't feel comfortable merging this right now, especially for the upcoming gosling release. The query still keeps an expression with the context held as state, which we should avoid. Returning from review for further discussion

[spring-projects-issues]

Christoph Strobl commented

updated the solution to spearate SpelExpression from the actual EvaluationContext