-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support Delete by query with es parameters. #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sothawo
requested changes
Mar 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I see two main issues:
- I don't think that
DeleteQuery
should derive fromBaseQuery
. This makes it implement theQuery
interface and so it could be used anywhere where aQuery
is expected, in searches, highlight etc. We'd need checks at any place where aQuery
is processed, that it is not aDeleteQuery
as this makes no sense. It should contain aQuery
, that's ok. LikeUpdateQuery
it should be an independent top level class with it's builder. - import of Elasticsearch classe, i left a note and the point in the
DeleteQuery
file.
src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java
Outdated
Show resolved
Hide resolved
sothawo
reviewed
Mar 17, 2024
src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java
Outdated
Show resolved
Hide resolved
sothawo
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nullability issue, otherwise some minor comments
src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/query/types/ConflictsType.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java
Outdated
Show resolved
Hide resolved
sothawo
requested changes
Mar 25, 2024
src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java
Show resolved
Hide resolved
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
Co-authored-by: Peter-Josef Meisch <pj.meisch@sothawo.com>
This commit updates the DeleteQuery to use internal classes instead of Elasticsearch classes. Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
sothawo
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2865