Skip to content

Commit 0fe11df

Browse files
committed
Polishing.
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
1 parent 2ab6dff commit 0fe11df

File tree

3 files changed

+19
-4
lines changed

3 files changed

+19
-4
lines changed

src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1014,7 +1014,15 @@ public DeleteByQueryRequest documentDeleteByQueryRequest(DeleteQuery query, @Nul
10141014
if (!sortOptions.isEmpty()) {
10151015
dqb.sort(
10161016
sortOptions.stream()
1017-
.map(sortOption -> sortOption.field().field() + ":" + sortOption.field().order().jsonValue())
1017+
.map(sortOption -> {
1018+
String order = "asc";
1019+
var sortField = sortOption.field();
1020+
if (sortField.order() != null) {
1021+
order = sortField.order().jsonValue();
1022+
}
1023+
1024+
return sortField.field() + ":" + order;
1025+
})
10181026
.collect(Collectors.toList())
10191027
);
10201028
}

src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
import org.springframework.data.elasticsearch.core.query.Query.SearchType;
2020
import org.springframework.data.elasticsearch.core.query.types.ConflictsType;
2121
import org.springframework.data.elasticsearch.core.query.types.OperatorType;
22+
import org.springframework.lang.NonNull;
2223
import org.springframework.lang.Nullable;
24+
import org.springframework.util.Assert;
2325

2426
import java.time.Duration;
2527
import java.util.EnumSet;
@@ -218,11 +220,11 @@ public class DeleteQuery {
218220
*/
219221
private final Query query;
220222

221-
public static Builder builder(Query query) {
223+
public static Builder builder(@NonNull Query query) {
222224
return new Builder(query);
223225
}
224226

225-
public DeleteQuery(Builder builder) {
227+
private DeleteQuery(Builder builder) {
226228
this.q = builder.luceneQuery;
227229
this.analyzeWildcard = builder.analyzeWildcard;
228230
this.analyzer = builder.analyzer;
@@ -449,7 +451,9 @@ public static final class Builder {
449451
// Body
450452
private final Query query;
451453

452-
private Builder(Query query) {
454+
private Builder(@NonNull Query query) {
455+
Assert.notNull(query, "query must not be null");
456+
453457
this.query = query;
454458
}
455459

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
@org.springframework.lang.NonNullApi
2+
@org.springframework.lang.NonNullFields
3+
package org.springframework.data.elasticsearch.core.query.types;

0 commit comments

Comments
 (0)