DATACOUCH-645 - Support Document(expiryExpression) annotation.

[mikereiche]

1. get the expiryExpression from the converted CouchbaseDocument.

2. added interfaces for apis on core objects which are common among
   many objects. For instance withExpiry and withExpirty on all the
   insert/replace/upsert/remove objects. The definition of an interface
   simplyfies testing of all the possible combinations - instead of having
   four (or eight, counting Reactive), there is one interface to test
   them all.

• You have read the Spring Data contribution guidelines.
• There is a ticket in the bug tracker for the project in our JIRA.
• You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.
• You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

[mp911de]

Mind the formatting. What's the reason for extracting all these interfaces into top-level ones? From a usage perspective, calling code would not mix replace and e.g. remove operations by reusing the same interface, would it?

[mikereiche]

fixed the formatting in this and the other interfaces.
From a usage perspective, the interfaces are not helpful. However, from a testing perspective, they allow testing all the implementers of those interfaces more easily. For testing withExpiry(), @document( expiry), and @document(@expiryExpression) (which require three different entity classes) across insert, replace and upsert, that would take 3 X 3 = 9 test cases. By having insert, replace and upsert implement OneAndAll and WithExpiry, all these tests can be done in a loop as in withExpiryAndExpiryAnnotation()
https://github.com/spring-projects/spring-data-couchbase/blob/7815522d682fceb0f55082ff825e6dabbd8a9343/src/test/java/org/springframework/data/couchbase/core/CouchbaseTemplateKeyValueIntegrationTests.java
(I was not able to figure out how to define an interface that would be also satisfied by the one() and all() of Remove)
I did promise @daschl that I would split this into two branches - one for the interfaces followed by a second for expiry - but it's hard to explain the interfaces without showing how they would be used.

[mp911de]

How would you express that a default expiry should be overridden to persistent (i.e. no expiry)?

[mikereiche]

Thats's a good point. It's not possible as an expiry of Zero gets ignored, resulting in the annotation being used.
The semantics could be changed to mean an expiry of Zero means to use zero as the expiry (to the server, this means no expiry). The 'expiry == null' meaning "don't use this, use the annotation instead" could be left as-is. The construction would need to be changed to be created with a null expiry instead of a Zero expiry.

		if (expiry != null && !expiry.isZero()) {
			options.expiry(expiry);
		} else if (doc.getExpiration() != 0) {
			options.expiry(Duration.ofSeconds(doc.getExpiration()));
		}