DATACOUCH-1041 - Add withCas() method to RemoveById. #1051
Conversation
Add withCas() method to RemoveById.
mikereiche
force-pushed
the
datacouch_1041_add_withCas_to_RemoveById
branch
from
6cbc63f to
cf820ce
Compare
| interface ExecutableRemoveById extends RemoveByIdWithDurability {} | ||
| interface RemoveByIdWithCas extends RemoveByIdWithDurability { | ||
|
|
||
| RemoveByIdWithDurability withCas(Long cas); |
There was a problem hiding this comment.
why is this a boxed long and not an unboxed long?
There was a problem hiding this comment.
So that null can have different semantics than zero.
| @@ -45,17 +46,19 @@ public ExecutableRemoveById removeById() { | |||
| private final PersistTo persistTo; | |||
| private final ReplicateTo replicateTo; | |||
| private final DurabilityLevel durabilityLevel; | |||
| private final Long cas; | |||
There was a problem hiding this comment.
same here, could this be a primitive long?
| interface ReactiveRemoveById extends RemoveByIdWithDurability {} | ||
| interface RemoveByIdWithCas extends RemoveByIdWithDurability { | ||
|
|
||
| RemoveByIdWithDurability withCas(Long cas); |
| @@ -81,28 +83,36 @@ private RemoveOptions buildRemoveOptions() { | |||
| } else if (durabilityLevel != DurabilityLevel.NONE) { | |||
| options.durability(durabilityLevel); | |||
| } | |||
| if (cas != null) { | |||
There was a problem hiding this comment.
I see the boxing and null, but it could just check if != 0 ?
There was a problem hiding this comment.
This comes from a comment made by Mark Paluch on another change-set regarding Expiry(I think). It's not quite the same for CAS, but I wanted to keep the same pattern/semantics - that null means "never been set/not specified", while an Object (including an object with value 0) means that it has been set.
In other words - something like this - That if it was set to non-Zero by an annotation, then there was no way to override (unset) it with the fluent call because it was already non-Duration.zero and the fluent call had to set it to Duration.zero, but Duration.zero (from the fluent call or otherwise) is treated as "never been set", so the value from the annotation would not be overridden. So null would have the semantics of "never been set", and Duration.zero has the semantics of "been set to zero".
Add withCas() method to RemoveById as the cas in the entity cannot be used as the entity is not pass in the API. The other option was to add methods like one(T entity) and all(Collection), but those class with one(String id) and all(Collection ids).