Fix links to snapshot and milestone in doc. #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
reviewed
Aug 13, 2021
| @@ -23,7 +23,7 @@ As a result, the library can be included like any other maven dependency: | |||
|
|
|||
| This will pull in several dependencies, including the underlying Couchbase Java SDK, common Spring dependencies and also Jackson as the JSON mapping infrastructure. | |||
|
|
|||
| You can also grab snapshots from the https://repo.spring.io/libs-snapshot[spring snapshot repository] and milestone releases from the https://repo.spring.io/libs-milestone[milestone repository]. | |||
| You can also grab snapshots from the https://repo.spring.io/ui/repos/tree/General/libs-snapshot/org/springframework/data/spring-data-couchbase[spring snapshot repository] ( \https://repo.spring.io/libs-snapshot ) and milestone releases from the https://repo.spring.io/ui/repos/tree/General/libs-milestone/org/springframework/data/spring-data-couchbase[spring milestone repository] ( \https://repo.spring.io/libs-milestone ). | |||
There was a problem hiding this comment.
do these links really work when put into a maven repository config? Since wen I click on them I get to the jfrug UI
There was a problem hiding this comment.
The old urls also redirect to the jfrog UI, but give 404. The urls in parentheses are the ones to plug into the maven repository config.
The urls in the example are ok, but when the hot link in the text is clicked on, it redirects to a 404. This fixes the hot links. Closes #1177.
mikereiche
force-pushed
the
datacouch_1177_fix_snapshot_milestone_urls_in_doc
branch
from
abe1172 to
e13cd49
Compare
mikereiche
deleted the
datacouch_1177_fix_snapshot_milestone_urls_in_doc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The urls in the example are ok, but when the hot link in the
text is clicked on, it redirects to a 404. This fixes the hot links.
Closes #1177.