DATACMNS-1827 - Consider Qualifier meta-annotated Sort method parameters. #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavic
commented
Nov 11, 2020
| @@ -293,6 +295,19 @@ static boolean notOnlyDots(String source) { | |||
| return StringUtils.hasText(source.replace(".", "")); | |||
| } | |||
|
|
|||
| @Nullable | |||
| private static String getQualifier(@Nullable MethodParameter parameter) { | |||
There was a problem hiding this comment.
@mp911de, since this piece of code duplicates the equally named method from PageableHandlerMethodArgumentResolverSupport, we could consider moving it to some utility class.
Not sure whether SpringDataAnnotationUtils is the right place, due to its (possibly outdated) javadoc?
There was a problem hiding this comment.
Yes, it makes sense. I'll take care of this during the merge.
mp911de
pushed a commit
that referenced
this pull request
Dec 1, 2020
…ers. Original pull request: #474.
mp911de
added a commit
that referenced
this pull request
Dec 1, 2020
Extract qualifier lookup into SpringDataAnnotationUtils. Original pull request: #474.
mp911de
pushed a commit
that referenced
this pull request
Dec 1, 2020
…ers. Original pull request: #474.
mp911de
added a commit
that referenced
this pull request
Dec 1, 2020
Extract qualifier lookup into SpringDataAnnotationUtils. Original pull request: #474.
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #473 that resolves DATACMNS-1827.