Skip to content

DATACMNS-1827 - Pageable and Sort arguments with empty qualifier value shouldn't be prefixed with delimiter. #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 9, 2020

This resolves DATACMNS-1827.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

mp911de pushed a commit that referenced this pull request Nov 11, 2020
…e shouldn't be prefixed with delimiter.

Original pull request: #473.
mp911de added a commit that referenced this pull request Nov 11, 2020
Consider Qualifier meta-annotated Sort and Pageable method parameters. Add author tag.

Original pull request: #473.
mp911de pushed a commit that referenced this pull request Nov 11, 2020
…e shouldn't be prefixed with delimiter.

Original pull request: #473.
mp911de added a commit that referenced this pull request Nov 11, 2020
Consider Qualifier meta-annotated Sort and Pageable method parameters. Add author tag.

Original pull request: #473.
@mp911de
Copy link
Member

mp911de commented Nov 11, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Nov 11, 2020
@vpavic vpavic deleted the DATACMNS-1827 branch November 11, 2020 08:40
@vpavic
Copy link
Contributor Author

vpavic commented Nov 11, 2020

@mp911de, I just noticed that you polish commit considered MergedAnnotations only for PageableHandlerMethodArgumentResolverSupport but not SortHandlerMethodArgumentResolverSupport - was that intentional?

@mp911de
Copy link
Member

mp911de commented Nov 11, 2020

Meh, I missed SortHandlerMethodArgumentResolverSupport. Do you want to submit a PR formten remaining one or should I take care of it?

@vpavic
Copy link
Contributor Author

vpavic commented Nov 11, 2020

I can handle it later in the day, I assume it's not that urgent as 2.4.1 seems to have went out few hours ago?
Also, having in mind that'll be targeted at 2.4.2, we need a new JIRA issue as well, right?

@mp911de
Copy link
Member

mp911de commented Nov 11, 2020

We can reuse the same issue and add 2.4.2 as fix version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants