Exclude local & anonymous classes from type inspection #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the type filter that would not mach types directly present in the given package. Modify type contribution method to allow store specific override.
Java8 bytecode may contain synthetic constructors that refer to anonymous classes which should not be inspected.
Eg. the following construct results in bytecode as listed further down below.
public enum Outer {
INSTANCE {
@OverRide
public Inner getInnerType() {
return Inner.STANDALONE;
}
},
public abstract Inner getInnerType();
}
synthetic Outer(java.lang.String arg0, int arg1, Inner$1 arg2)
mp911de
reviewed
Dec 9, 2022
| @@ -125,6 +127,10 @@ Set<Type> visitConstructorsOfType(ResolvableType type) { | |||
| } | |||
| Set<Type> discoveredTypes = new LinkedHashSet<>(); | |||
| for (Constructor<?> constructor : type.toClass().getDeclaredConstructors()) { | |||
|
|
|||
| if (constructor.isSynthetic()) { | |||
There was a problem hiding this comment.
Kotlin likes to generate synthetic constructors for data classes. We should make sure to not break stuff. Likely, the field-based inspection is going to catch such cases.
There was a problem hiding this comment.
mp911de
pushed a commit
that referenced
this pull request
Jan 11, 2023
Java8 bytecode may contain synthetic constructors that refer to anonymous classes which should not be inspected.
Eg. the following construct results in bytecode as listed further down below.
public enum Outer {
INSTANCE {
@OverRide
public Inner getInnerType() {
return Inner.STANDALONE;
}
},
public abstract Inner getInnerType();
}
synthetic Outer(java.lang.String arg0, int arg1, Inner$1 arg2)
See: #2744
Original pull request: #2746
mp911de
pushed a commit
that referenced
this pull request
Jan 11, 2023
Java8 bytecode may contain synthetic constructors that refer to anonymous classes which should not be inspected.
Eg. the following construct results in bytecode as listed further down below.
public enum Outer {
INSTANCE {
@OverRide
public Inner getInnerType() {
return Inner.STANDALONE;
}
},
public abstract Inner getInnerType();
}
synthetic Outer(java.lang.String arg0, int arg1, Inner$1 arg2)
See: #2744
Original pull request: #2746
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local and anonymous classes should not be picked up during reachable type collection, as those are not targets of the spring data reflection infrastructure.
We also updated the type filter so that it now matches types present in the very same package and modified method visibility for module specific contribution checks.
Last we excluded synthetic constructors from being inspected as those (in some cases) can contain references to anonymous classes as shown in the snippet below.