Remove punctuation in all exception messages.

Closes #2603.

Author: jo

src/main/java/org/springframework/data/auditing/AnnotationAuditingMetadata.java

@@ -41,6 +41,7 @@
  * @author Ranie Jade Ramiso
  * @author Oliver Gierke
  * @author Christoph Strobl
+ * @author Johannes Englmeier
  * @since 1.5
  */
 final class AnnotationAuditingMetadata {
@@ -108,7 +109,7 @@ private void assertValidDateFieldType(Optional<Field> field) {
 			}
 
 			throw new IllegalStateException(String.format(
-					"Found created/modified date field with type %s but only %s as well as java.time types are supported!", type,
+					"Found created/modified date field with type %s but only %s as well as java.time types are supported", type,
 					SUPPORTED_DATE_TYPES));
 		});
 	}

src/main/java/org/springframework/data/auditing/DefaultAuditableBeanWrapperFactory.java

@@ -38,6 +38,7 @@
  * @author Christoph Strobl
  * @author Jens Schauder
  * @author Pavel Horal
+ * @author Johannes Englmeier
  * @since 1.5
  */
 class DefaultAuditableBeanWrapperFactory implements AuditableBeanWrapperFactory {
@@ -187,7 +188,7 @@ protected Object getDateValueToSet(TemporalAccessor value, Class<?> targetType,
 
 				if (!conversionService.canConvert(value.getClass(), Date.class)) {
 					throw new IllegalArgumentException(
-							String.format("Cannot convert date type for member %s! From %s to java.util.Date to %s.", source,
+							String.format("Cannot convert date type for member %s! From %s to java.util.Date to %s", source,
 									value.getClass(), targetType));
 				}
 
@@ -227,7 +228,7 @@ protected <S extends TemporalAccessor> Optional<S> getAsTemporalAccessor(Optiona
 	}
 
 	private static IllegalArgumentException rejectUnsupportedType(Object source) {
-		return new IllegalArgumentException(String.format("Invalid date type %s for member %s! Supported types are %s.",
+		return new IllegalArgumentException(String.format("Invalid date type %s for member %s! Supported types are %s",
 				source.getClass(), source, AnnotationAuditingMetadata.SUPPORTED_DATE_TYPES));
 	}
 

src/main/java/org/springframework/data/config/ConfigurationUtils.java

@@ -25,6 +25,7 @@
  * implementation.
  *
  * @author Oliver Gierke
+ * @author Johannes Englmeier
  * @since 2.0
  * @soundtrack Richard Spaven - The Self (feat. Jordan Rakei)
  */
@@ -44,7 +45,7 @@ public static ResourceLoader getRequiredResourceLoader(XmlReaderContext context)
 		ResourceLoader resourceLoader = context.getResourceLoader();
 
 		if (resourceLoader == null) {
-			throw new IllegalArgumentException("Could not obtain ResourceLoader from XmlReaderContext!");
+			throw new IllegalArgumentException("Could not obtain ResourceLoader from XmlReaderContext");
 		}
 
 		return resourceLoader;
@@ -75,7 +76,7 @@ public static ClassLoader getRequiredClassLoader(ResourceLoader resourceLoader)
 		ClassLoader classLoader = resourceLoader.getClassLoader();
 
 		if (classLoader == null) {
-			throw new IllegalArgumentException("Could not obtain ClassLoader from ResourceLoader!");
+			throw new IllegalArgumentException("Could not obtain ClassLoader from ResourceLoader");
 		}
 
 		return classLoader;
@@ -96,7 +97,7 @@ public static String getRequiredBeanClassName(BeanDefinition beanDefinition) {
 
 		if (result == null) {
 			throw new IllegalArgumentException(
-					String.format("Could not obtain required bean class name from BeanDefinition!", beanDefinition));
+					String.format("Could not obtain required bean class name from BeanDefinition", beanDefinition));
 		}
 
 		return result;

src/main/java/org/springframework/data/convert/ConfigurableTypeInformationMapper.java

@@ -33,6 +33,7 @@
  * inspecting the {@link PersistentEntity} instances for type alias information.
  *
  * @author Oliver Gierke
+ * @author Johannes Englmeier
  */
 public class ConfigurableTypeInformationMapper implements TypeInformationMapper {
 
@@ -58,7 +59,7 @@ public ConfigurableTypeInformationMapper(Map<? extends Class<?>, String> sourceT
 
 			if (typeToAlias.containsValue(alias)) {
 				throw new IllegalArgumentException(
-						String.format("Detected mapping ambiguity! String %s cannot be mapped to more than one type!", alias));
+						String.format("Detected mapping ambiguity! String %s cannot be mapped to more than one type", alias));
 			}
 
 			this.typeToAlias.put(type, alias);

src/main/java/org/springframework/data/convert/CustomConversions.java

@@ -54,6 +54,7 @@
  * @author Christoph Strobl
  * @author Mark Paluch
  * @author Xeno Amess
+ * @author Johannes Englmeier
  * @since 2.0
  */
 public class CustomConversions {

src/main/java/org/springframework/data/convert/DefaultConverterBuilder.java

@@ -38,6 +38,7 @@
  *
  * @author Oliver Gierke
  * @author Mark Paluch
+ * @author Johannes Englmeier
  * @since 2.0
  * @see ConverterBuilder#writing(Class, Class, Function)
  * @see ConverterBuilder#reading(Class, Class, Function)
@@ -61,13 +62,13 @@ public ConverterAware andWriting(Function<? super S, ? extends T> function) {
 	@Override
 	public GenericConverter getReadingConverter() {
 		return getOptionalReadingConverter()
-				.orElseThrow(() -> new IllegalStateException("No reading converter specified!"));
+				.orElseThrow(() -> new IllegalStateException("No reading converter specified"));
 	}
 
 	@Override
 	public GenericConverter getWritingConverter() {
 		return getOptionalWritingConverter()
-				.orElseThrow(() -> new IllegalStateException("No writing converter specified!"));
+				.orElseThrow(() -> new IllegalStateException("No writing converter specified"));
 	}
 
 	@Override

src/main/java/org/springframework/data/convert/MappingContextTypeInformationMapper.java

@@ -34,6 +34,7 @@
  *
  * @author Oliver Gierke
  * @author Christoph Strobl
+ * @author Johannes Englmeier
  */
 public class MappingContextTypeInformationMapper implements TypeInformationMapper {
 
@@ -87,7 +88,7 @@ private Alias verify(ClassTypeInformation<?> key, Alias alias) {
 		if (existingAlias.isPresentButDifferent(alias)) {
 
 			throw new IllegalArgumentException(
-					String.format("Trying to register alias '%s', but found already registered alias '%s' for type %s!", alias,
+					String.format("Trying to register alias '%s', but found already registered alias '%s' for type %s", alias,
 							existingAlias, key));
 		}
 
@@ -100,7 +101,7 @@ private Alias verify(ClassTypeInformation<?> key, Alias alias) {
 					.findFirst().ifPresent(it -> {
 
 						throw new IllegalArgumentException(String.format(
-								"Detected existing type mapping of %s to alias '%s' but attempted to bind the same alias to %s!", key,
+								"Detected existing type mapping of %s to alias '%s' but attempted to bind the same alias to %s", key,
 								alias, it.getKey()));
 					});
 		}

src/main/java/org/springframework/data/crossstore/ChangeSetBackedTransactionSynchronization.java

@@ -19,7 +19,9 @@
 import org.apache.commons.logging.LogFactory;
 
 import org.springframework.transaction.support.TransactionSynchronization;
-
+/**
+ * @author Johannes Englmeier
+ */
 public class ChangeSetBackedTransactionSynchronization implements TransactionSynchronization {
 
 	private static final Log logger = LogFactory.getLog(ChangeSetBackedTransactionSynchronization.class);
@@ -63,12 +65,12 @@ public void flush() {
 
 	public void resume() {
 		throw new IllegalStateException(
-				"ChangedSetBackedTransactionSynchronization does not support transaction suspension currently.");
+				"ChangedSetBackedTransactionSynchronization does not support transaction suspension currently");
 	}
 
 	public void suspend() {
 		throw new IllegalStateException(
-				"ChangedSetBackedTransactionSynchronization does not support transaction suspension currently.");
+				"ChangedSetBackedTransactionSynchronization does not support transaction suspension currently");
 	}
 
 }

src/main/java/org/springframework/data/domain/AbstractPageRequest.java

@@ -23,6 +23,7 @@
  * @author Thomas Darimont
  * @author Oliver Gierke
  * @author Alex Bondarev
+ * @author Johannes Englmeier
  */
 public abstract class AbstractPageRequest implements Pageable, Serializable {
 
@@ -41,11 +42,11 @@ public abstract class AbstractPageRequest implements Pageable, Serializable {
 	public AbstractPageRequest(int page, int size) {
 
 		if (page < 0) {
-			throw new IllegalArgumentException("Page index must not be less than zero!");
+			throw new IllegalArgumentException("Page index must not be less than zero");
 		}
 
 		if (size < 1) {
-			throw new IllegalArgumentException("Page size must not be less than one!");
+			throw new IllegalArgumentException("Page size must not be less than one");
 		}
 
 		this.page = page;

src/main/java/org/springframework/data/domain/Sort.java

@@ -40,6 +40,7 @@
  * @author Oliver Gierke
  * @author Thomas Darimont
  * @author Mark Paluch
+ * @author Johannes Englmeier
  */
 public class Sort implements Streamable<org.springframework.data.domain.Sort.Order>, Serializable {
 
@@ -64,7 +65,7 @@ protected Sort(List<Order> orders) {
 	private Sort(Direction direction, List<String> properties) {
 
 		if (properties == null || properties.isEmpty()) {
-			throw new IllegalArgumentException("You have to provide at least one property to sort by!");
+			throw new IllegalArgumentException("You have to provide at least one property to sort by");
 		}
 
 		this.orders = properties.stream() //
@@ -304,7 +305,7 @@ public static Direction fromString(String value) {
 				return Direction.valueOf(value.toUpperCase(Locale.US));
 			} catch (Exception e) {
 				throw new IllegalArgumentException(String.format(
-						"Invalid value '%s' for orders given! Has to be either 'desc' or 'asc' (case insensitive).", value), e);
+						"Invalid value '%s' for orders given! Has to be either 'desc' or 'asc' (case insensitive)", value), e);
 			}
 		}
 
@@ -436,7 +437,7 @@ public static Order desc(String property) {
 		private Order(@Nullable Direction direction, String property, boolean ignoreCase, NullHandling nullHandling) {
 
 			if (!StringUtils.hasText(property)) {
-				throw new IllegalArgumentException("Property must not be null or empty!");
+				throw new IllegalArgumentException("Property must not be null or empty");
 			}
 
 			this.direction = direction == null ? DEFAULT_DIRECTION : direction;

src/main/java/org/springframework/data/history/AnnotationRevisionMetadata.java

@@ -36,6 +36,7 @@
  * @author Oliver Gierke
  * @author Jens Schauder
  * @author Mark Paluch
+ * @author Johannes Englmeier
  */
 public class AnnotationRevisionMetadata<N extends Number & Comparable<N>> implements RevisionMetadata<N> {
 
@@ -135,6 +136,6 @@ private static Instant convertToInstant(Object timestamp) {
 			return ((Date) timestamp).toInstant();
 		}
 
-		throw new IllegalArgumentException(String.format("Can't convert %s to Instant!", timestamp));
+		throw new IllegalArgumentException(String.format("Can't convert %s to Instant", timestamp));
 	}
 }

src/main/java/org/springframework/data/history/RevisionMetadata.java

@@ -24,6 +24,7 @@
  * @author Philipp Huegelmeyer
  * @author Oliver Gierke
  * @author Jens Schauder
+ * @author Johannes Englmeier
  */
 public interface RevisionMetadata<N extends Number & Comparable<N>> {
 
@@ -43,7 +44,7 @@ public interface RevisionMetadata<N extends Number & Comparable<N>> {
 	default N getRequiredRevisionNumber() {
 
 		return getRevisionNumber().orElseThrow(
-				() -> new IllegalStateException(String.format("No revision number found on %s!", this.<Object> getDelegate())));
+				() -> new IllegalStateException(String.format("No revision number found on %s", this.<Object> getDelegate())));
 	}
 
 	/**
@@ -62,7 +63,7 @@ default N getRequiredRevisionNumber() {
 	default Instant getRequiredRevisionInstant() {
 
 		return getRevisionInstant().orElseThrow(
-				() -> new IllegalStateException(String.format("No revision date found on %s!", this.<Object> getDelegate())));
+				() -> new IllegalStateException(String.format("No revision date found on %s", this.<Object> getDelegate())));
 	}
 
 	/**

src/main/java/org/springframework/data/mapping/IdentifierAccessor.java

@@ -22,6 +22,7 @@
  *
  * @author Oliver Gierke
  * @author Mark Paluch
+ * @author Johannes Englmeier
  * @see TargetAwareIdentifierAccessor
  */
 public interface IdentifierAccessor {
@@ -51,6 +52,6 @@ default Object getRequiredIdentifier() {
 			return identifier;
 		}
 
-		throw new IllegalStateException("Could not obtain identifier!");
+		throw new IllegalStateException("Could not obtain identifier");
 	}
 }

src/main/java/org/springframework/data/mapping/PersistentEntity.java

@@ -32,6 +32,7 @@
  * @author Patryk Wasik
  * @author Mark Paluch
  * @author Christoph Strobl
+ * @author Johannes Englmeier
  */
 public interface PersistentEntity<T, P extends PersistentProperty<P>> extends Iterable<P> {
 
@@ -131,7 +132,7 @@ default P getRequiredIdProperty() {
 			return property;
 		}
 
-		throw new IllegalStateException(String.format("Required identifier property not found for %s!", getType()));
+		throw new IllegalStateException(String.format("Required identifier property not found for %s", getType()));
 	}
 
 	/**
@@ -159,7 +160,7 @@ default P getRequiredVersionProperty() {
 			return property;
 		}
 
-		throw new IllegalStateException(String.format("Required version property not found for %s!", getType()));
+		throw new IllegalStateException(String.format("Required version property not found for %s", getType()));
 	}
 
 	/**
@@ -186,7 +187,7 @@ default P getRequiredPersistentProperty(String name) {
 			return property;
 		}
 
-		throw new IllegalStateException(String.format("Required property %s not found for %s!", name, getType()));
+		throw new IllegalStateException(String.format("Required property %s not found for %s", name, getType()));
 	}
 
 	/**
@@ -312,7 +313,7 @@ default <A extends Annotation> A getRequiredAnnotation(Class<A> annotationType)
 		}
 
 		throw new IllegalStateException(
-				String.format("Required annotation %s not found for %s!", annotationType, getType()));
+				String.format("Required annotation %s not found for %s", annotationType, getType()));
 	}
 
 	/**

src/main/java/org/springframework/data/mapping/PersistentProperty.java

@@ -34,6 +34,7 @@
  * @author Mark Paluch
  * @author Jens Schauder
  * @author Christoph Strobl
+ * @author Johannes Englmeier
  */
 public interface PersistentProperty<P extends PersistentProperty<P>> {
 
@@ -89,7 +90,7 @@ default Method getRequiredGetter() {
 		Method getter = getGetter();
 
 		if (getter == null) {
-			throw new IllegalArgumentException(String.format("No getter available for persistent property %s!", this));
+			throw new IllegalArgumentException(String.format("No getter available for persistent property %s", this));
 		}
 
 		return getter;
@@ -109,7 +110,7 @@ default Method getRequiredSetter() {
 		Method setter = getSetter();
 
 		if (setter == null) {
-			throw new IllegalArgumentException(String.format("No setter available for persistent property %s!", this));
+			throw new IllegalArgumentException(String.format("No setter available for persistent property %s", this));
 		}
 
 		return setter;
@@ -147,7 +148,7 @@ default Method getRequiredWither() {
 		Method wither = getWither();
 
 		if (wither == null) {
-			throw new IllegalArgumentException(String.format("No wither available for persistent property %s!", this));
+			throw new IllegalArgumentException(String.format("No wither available for persistent property %s", this));
 		}
 
 		return wither;
@@ -161,7 +162,7 @@ default Field getRequiredField() {
 		Field field = getField();
 
 		if (field == null) {
-			throw new IllegalArgumentException(String.format("No field backing persistent property %s!", this));
+			throw new IllegalArgumentException(String.format("No field backing persistent property %s", this));
 		}
 
 		return field;
@@ -193,7 +194,7 @@ default Association<P> getRequiredAssociation() {
 			return association;
 		}
 
-		throw new IllegalStateException("No association found!");
+		throw new IllegalStateException("No association found");
 	}
 
 	/**