-
Notifications
You must be signed in to change notification settings - Fork 216
Custom naming for serverless-step-functions #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom naming for serverless-step-functions #50
Conversation
Sorry it took a while to get the lint/tests necessary updates. |
First off 👏 A few questions though: In your example code above you have this line:
But you have omitted the Resources->Outputs section from the example. Was that just an oversight or does this PR automatically add step function arns to outputs as well? Also, for your name you have e.g.
|
I would recommend adding this field to the main Readme.md also: https://github.com/horike37/serverless-step-functions/blob/master/README.md#setup Maybe also update the Tips example at the bottom. |
** I'm on mobile at the moment so my answer may be short and have spelling errors. The leftover Looks like the following will find the stepFunction and ignore the trailing characters.
|
Suuuuuuper Cool @icarus-sullivan!!! I will test it locally. However I am busy in this week, please give me a little time. |
Thank you for this @icarus-sullivan ! |
Allow users to provide their own stepMachine naming convention.
example