-_- adding tests, more lint fixes

Author: Chris Sullivan

lib/deploy/stepFunctions/compileStateMachines.js

@@ -12,7 +12,7 @@ module.exports = {
         let DependsOn;
         let Name;
 
-        if (stateMachineObj.hasOwnProperty('Name')) {
+        if (stateMachineObj.Name) {
           Name = stateMachineObj.Name;
         }
 

lib/deploy/stepFunctions/compileStateMachines.test.js

@@ -76,6 +76,55 @@ describe('#compileStateMachines', () => {
     ).to.equal('MyStateMachine2StepFunctionsStateMachine');
   });
 
+  it('should create named resources when Name is provided', () => {
+    serverless.service.stepFunctions = {
+      stateMachines: {
+        myStateMachine1: {
+          definition: 'definition1',
+          Name: 'stateMachineBeta1',
+        },
+        myStateMachine2: {
+          definition: 'definition2',
+          Name: 'stateMachineBeta2',
+        },
+      },
+    };
+
+    serverlessStepFunctions.compileStateMachines();
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta1.Type
+    ).to.equal('AWS::StepFunctions::StateMachine');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta2.Type
+    ).to.equal('AWS::StepFunctions::StateMachine');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta1.Properties.DefinitionString
+    ).to.equal('"definition1"');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta2.Properties.DefinitionString
+    ).to.equal('"definition2"');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta1.Properties.RoleArn['Fn::GetAtt'][0]
+    ).to.equal('IamRoleStateMachineExecution');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta2.Properties.RoleArn['Fn::GetAtt'][0]
+    ).to.equal('IamRoleStateMachineExecution');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta1.DependsOn
+    ).to.equal('IamRoleStateMachineExecution');
+    expect(serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .StateMachineBeta2.DependsOn
+    ).to.equal('IamRoleStateMachineExecution');
+  });
+
   it('should create corresponding resources when definition and role property are given', () => {
     serverless.service.stepFunctions = {
       stateMachines: {

lib/naming.js

@@ -11,7 +11,7 @@ module.exports = {
 
   getStateMachineOutputLogicalId(stateMachineName, Name) {
     if (Name) {
-      return `${this.provider.naming.getNormalizedFunctionName(Name)}`;
+      return `${this.provider.naming.getNormalizedFunctionName(Name)}Arn`;
     }
     return `${this.provider.naming
       .getNormalizedFunctionName(stateMachineName)}StepFunctionsStateMachineArn`;

lib/naming.test.js

@@ -32,6 +32,20 @@ describe('#naming', () => {
     });
   });
 
+  describe('#getStateMachineLogicalId() -- Named', () => {
+    it('should normalize the stateMachine name and add the standard suffix', () => {
+      expect(serverlessStepFunctions.getStateMachineLogicalId('stateMachine', 'alphaNumeric')).to
+      .equal('AlphaNumeric');
+    });
+  });
+
+  describe('#getStateMachineOutputLogicalId() -- Named', () => {
+    it('should normalize the stateMachine output name and add the standard suffix', () => {
+      expect(serverlessStepFunctions.getStateMachineOutputLogicalId('stateMachine', 'alphaNumeric'))
+      .to.equal('AlphaNumericArn');
+    });
+  });
+
   describe('#getActivityLogicalId()', () => {
     it('should normalize the activity name and add the standard suffix', () => {
       expect(serverlessStepFunctions.getActivityLogicalId('activity')).to