Fixed yaml model (insecureSkipTlsVerify) #177
Conversation
| .withSSL( | ||
| (config.getCurrentAuthInfo().isInsecureSkipTlsVerify() | ||
| (config.getCurrentDatacenter().isInsecureSkipTlsVerify() | ||
| ? config.createBundle().getInsecureSSLOptions() | ||
| : config.createBundle().getSSLOptions())) |
There was a problem hiding this comment.
A potential problem I see (and I didn't expect at the beginning): Previously, there was only a single insecureSkipTlsVerify, so we could set it here with withSSL on a session. But now, you could have different configurations of insecureSkipTlsVerify per each datacenter - but here currentDatacenter determines the configuration for all SSL connections.
|
@wprzytula Could you rebase on top of latest I think that we will merge the current version (since Python version with the same problem was already merged and CCM was changed) and just put an issue to fix this in the future - the first iteration of serverless is a single-DC serverless. |
wprzytula
force-pushed
the
cloud_yaml_model_fix
branch
from
a62e7ef to
16c655c
Compare
|
@wprzytula Sorry to ask again for rebasing - the test failed due to unrelated reasons to this PR. The |
wprzytula
force-pushed
the
cloud_yaml_model_fix
branch
from
16c655c to
d6a1726
Compare
Field insecureSkipTlsVerify was incorrectly put in AuthInfo instead of Datacenter.
|
@wprzytula Merged the commit. The commit message should be more descriptive of the change (not generic "fixed yaml model"). I fixed it myself - 22e3ad5 |
Update the version of Java Driver from 3.11.2.1 to 3.11.2.4. The differences between the versions are fixes to serverless support: 1. Driver connecting to address in "Server" field of the bundle instead of "NodeDomain" (scylladb/java-driver#173) 2. Moving parsing of "insecureSkipTlsVerify" from "AuthInfo" field in serverless bundle file to "Datacenter" fields (scylladb/java-driver#177) Without this change, cassandra-stress could not connect correctly to a local serverless cluster created with Scylla Operator or CCM (see scylladb/java-driver#164).
Update the version of Java Driver from 3.11.2.1 to 3.11.2.4. The differences between the versions are fixes to serverless support: 1. Driver connecting to address in "Server" field of the bundle instead of "NodeDomain" (scylladb/java-driver#173) 2. Moving parsing of "insecureSkipTlsVerify" from "AuthInfo" field in serverless bundle file to "Datacenter" fields (scylladb/java-driver#177) Without this change, cassandra-stress could not connect correctly to a local serverless cluster created with Scylla Operator or CCM (see scylladb/java-driver#164). Closes #321
Field insecureSkipTlsVerify was incorrectly put in AuthInfo instead of Datacenter.