Move insecureSkipTlsVerify to each Datacenter

Previously in the serverless bundle file "insecureSkipTlsVerify" field 
was incorrectly put in AuthInfo instead of Datacenter.

This change moves "insecureSkipTlsVerify" field to each Datacenter.
Similar changes were already done in: scylladb/scylla-ccm#419 and
scylladb/python-driver#186.

Author: wprzytula

driver-core/src/main/java/com/datastax/driver/core/Cluster.java

@@ -1408,7 +1408,7 @@ protected Builder withScyllaCloudConnectionConfig(ScyllaCloudConnectionConfig co
                     new ScyllaCloudSniEndPointFactory(
                         proxyAddress, currentDatacenter.getNodeDomain()))
                 .withSSL(
-                    (config.getCurrentAuthInfo().isInsecureSkipTlsVerify()
+                    (config.getCurrentDatacenter().isInsecureSkipTlsVerify()
                         ? config.createBundle().getInsecureSSLOptions()
                         : config.createBundle().getSSLOptions()))
                 .withAuthProvider(

driver-core/src/main/java/com/datastax/driver/core/ScyllaCloudAuthInfo.java

@@ -26,7 +26,6 @@ class ScyllaCloudAuthInfo {
   private final String clientKeyPath;
   private final String username;
   private final String password;
-  private final boolean insecureSkipTlsVerify;
 
   @JsonCreator
   public ScyllaCloudAuthInfo(
@@ -35,16 +34,13 @@ public ScyllaCloudAuthInfo(
       @JsonProperty(value = "clientKeyData") byte[] clientKeyData,
       @JsonProperty(value = "clientKeyPath") String clientKeyPath,
       @JsonProperty(value = "username") String username,
-      @JsonProperty(value = "password") String password,
-      @JsonProperty(value = "insecureSkipTlsVerify", defaultValue = "false")
-          boolean insecureSkipTlsVerify) {
+      @JsonProperty(value = "password") String password) {
     this.clientCertificateData = clientCertificateData;
     this.clientCertificatePath = clientCertificatePath;
     this.clientKeyData = clientKeyData;
     this.clientKeyPath = clientKeyPath;
     this.username = username;
     this.password = password;
-    this.insecureSkipTlsVerify = insecureSkipTlsVerify;
   }
 
   public void validate() {
@@ -96,8 +92,4 @@ public String getUsername() {
   public String getPassword() {
     return password;
   }
-
-  public boolean isInsecureSkipTlsVerify() {
-    return insecureSkipTlsVerify;
-  }
 }

driver-core/src/main/java/com/datastax/driver/core/ScyllaCloudDatacenter.java

@@ -20,6 +20,7 @@ class ScyllaCloudDatacenter {
   private final String tlsServerName;
   private final String nodeDomain;
   private final String proxyURL;
+  private final boolean insecureSkipTlsVerify;
 
   // Full hostname has limit of 255 chars.
   // Host UUID takes 32 chars for hex digits and 4 dashes. Additional 1 is for separator dot before
@@ -33,13 +34,16 @@ public ScyllaCloudDatacenter(
       @JsonProperty(value = "server") String server,
       @JsonProperty(value = "tlsServerName") String tlsServerName,
       @JsonProperty(value = "nodeDomain") String nodeDomain,
-      @JsonProperty(value = "proxyURL") String proxyURL) {
+      @JsonProperty(value = "proxyURL") String proxyURL,
+      @JsonProperty(value = "insecureSkipTlsVerify", defaultValue = "false")
+          boolean insecureSkipTlsVerify) {
     this.certificateAuthorityPath = certificateAuthorityPath;
     this.certificateAuthorityData = certificateAuthorityData;
     this.server = server;
     this.tlsServerName = tlsServerName;
     this.nodeDomain = nodeDomain;
     this.proxyURL = proxyURL;
+    this.insecureSkipTlsVerify = insecureSkipTlsVerify;
   }
 
   public void validate() {
@@ -85,6 +89,10 @@ public String getProxyURL() {
     return proxyURL;
   }
 
+  public boolean isInsecureSkipTlsVerify() {
+    return insecureSkipTlsVerify;
+  }
+
   // Using parts relevant to hostnames as we're dealing with a part of hostname
   // RFC-1123 Section 2.1 and RFC-952 1.
   private void validateNodeDomain() {