Skip to content

Added link #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

MaheshVishnu
Copy link

@MaheshVishnu MaheshVishnu commented Jun 18, 2018

Added a link to BalancedBaggingClassifier and EasyEnsemble

Reference Issue

This is on issue #388

What does this implement/fix?

I tried to add the link between EasyEnsemble and BalancedBaggingClassifier by documenting that they are synonyms in easy_ensemble.py file.

Added a link to BalancedBaggingClassifier and EasyEnsemble
@pep8speaks
Copy link

pep8speaks commented Jun 18, 2018

Hello @MaheshVishnu! Thanks for updating the PR.

Line 8:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 12:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file

Comment last updated on June 18, 2018 at 18:09 Hours UTC

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          70       70           
  Lines        4188     4188           
=======================================
  Hits         4134     4134           
  Misses         54       54
Impacted Files Coverage Δ
imblearn/ensemble/easy_ensemble.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fed48f...dc306ed. Read the comment docs.

@@ -4,6 +4,7 @@
# Christos Aridas
# License: MIT

#EasyEnsemble is also called as BalancedBaggingClassifier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop you should make an entry inside the docstring in the "Notes" section and in the "See also"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants