Skip to content

DOC fix typo in ref, add pdf link to ref and add references.bib #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ybayle
Copy link
Contributor

@ybayle ybayle commented Jan 11, 2018

What does this implement/fix? Explain your changes.

  • fix typo and errors in references
  • add pdf link in references
  • add references.bib
  • add bib link in references

Any other comments?

bib file processed with bibtool

@glemaitre
Copy link
Member

Sorry for the delay. Could you rebase master once that #392. It should remove the failure of the CI.

Regarding your PR, if we go this way, we would need to update the references in the docstring of each method.

@ybayle
Copy link
Contributor Author

ybayle commented Jan 17, 2018

Sorry for the delay. Could you rebase master once that #392. It should remove the failure of the CI.

Can you ping me when #392 will be solved and merged? So that I can rebase.

Regarding your PR, if we go this way, we would need to update the references in the docstring of each method.

Do I need to wait for the validation of this PR before adding a new PR to the docstring or should I make a common one?

@glemaitre
Copy link
Member

glemaitre commented Jan 17, 2018 via email

@glemaitre
Copy link
Member

#392 has been merged. We are good on our side :)

@glemaitre glemaitre force-pushed the master branch 5 times, most recently from bf1ec62 to 23ad602 Compare February 28, 2018 22:36
@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          70       70           
  Lines        4188     4188           
=======================================
  Hits         4134     4134           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4271d9...30f0315. Read the comment docs.

@ybayle
Copy link
Contributor Author

ybayle commented Jun 7, 2018

Hi,
Sorry for the delay (moreover, I did not see the update on this). I hope everything should be ok now?

@glemaitre glemaitre merged commit 7c5e5da into scikit-learn-contrib:master Jun 7, 2018
@glemaitre
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants