Skip to content

[MRG] FIX ADASYN generate from minority class only #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

glemaitre
Copy link
Member

Reference Issue

Closes #298

What does this implement/fix? Explain your changes.

Any other comments?

@glemaitre
Copy link
Member Author

@massich @chkoar Reviews welcomed

@codecov
Copy link

codecov bot commented Jun 23, 2017

Codecov Report

Merging #299 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   98.36%   98.36%   +<.01%     
==========================================
  Files          66       66              
  Lines        3857     3859       +2     
==========================================
+ Hits         3794     3796       +2     
  Misses         63       63
Impacted Files Coverage Δ
imblearn/over_sampling/adasyn.py 97.77% <100%> (+0.1%) ⬆️
imblearn/over_sampling/tests/test_adasyn.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ccf10...9cec513. Read the comment docs.

@massich
Copy link
Contributor

massich commented Jun 23, 2017

LGTM !
The results are worst, but if the paper resamples only from the minority class, that's what we should do.

@chkoar
Copy link
Member

chkoar commented Jun 26, 2017

@glemaitre I think that @massich is quite right. We should implement the algorithm from the paper. Another option it could be to leave it as parameter with the default to perform the sampling from the minority class and state somewhere in the documentation the empirical findings.

@glemaitre
Copy link
Member Author

@chkoar I am not even sure that it will impact so much the decision function at the end.
Could you merge the PR if this is fine with you.

@chkoar chkoar merged commit f4753f2 into scikit-learn-contrib:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A problem about ADASYN
3 participants