Support Enums in SwingObjectWidget #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagejan
force-pushed
the
enum-object-widget
branch
from
ed55e27 to
0111530
Compare
imagejan
force-pushed
the
enum-object-widget
branch
from
0111530 to
248b249
Compare
ctrueden
force-pushed
the
enum-object-widget
branch
from
0417191 to
49cd93c
Compare
For Enum parameters, model.getChoices() returns all available enum values by default, so let's just support any model that has valid choices. This commit also adds a test for SwingObjectWidget, testing Enum parameters as well as Object parameters with and without objects in their object pool.
ctrueden
force-pushed
the
enum-object-widget
branch
from
49cd93c to
7d36b38
Compare
|
Thank you, @imagejan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Enum parameters, model.getChoices() returns all available enum values by default, so let's just support any model that has valid choices.
This commit also adds a test for SwingObjectWidget, testing Enum parameters as well as Object parameters with and without objects in their object pool.
This PR currently depends on scijava/scijava-common#400 that adds a required
nullcheck, so that PR should be merged and this one updated with a newer version ofscijava-common.Closes scijava/scijava-common#397.