Skip to content

DefaultWidgetModel: check for null choicesList #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

DefaultWidgetModel: check for null choicesList #400

merged 1 commit into from
Dec 15, 2021

Conversation

imagejan
Copy link
Member

Let's fail fast and return null when item.getChoices() returns null.

@imagejan imagejan mentioned this pull request Oct 16, 2020
Merged
@imagejan
DefaultWidgetModel: check for null choicesList
c8ab4ad 
Let's fail fast and return null when item.getChoices() returns null.
@imagejan imagejan requested review from ctrueden and hinerm February 23, 2021 10:46
@ctrueden ctrueden merged commit 5e17ffb into master Dec 15, 2021
@ctrueden ctrueden deleted the empty-choices branch December 15, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrueden ctrueden Awaiting requested review from ctrueden

@hinerm hinerm Awaiting requested review from hinerm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imagejan @ctrueden