Hide "Parallelize position pickling" under a flag #9645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Aug 26, 2020
smarter
changed the title
smarter
force-pushed
the
revert-9619-parallel-position-pickler
branch
from
4556520 to
75360b1
Compare
OK, that's a compelling argument! |
odersky
approved these changes
Aug 26, 2020
odersky
reviewed
Aug 26, 2020
| @@ -86,7 +86,17 @@ class Pickler extends Phase { | |||
| pickled | |||
| }(using ExecutionContext.global) | |||
| def force(): Array[Byte] = Await.result(pickledF, Duration.Inf) | |||
| if ctx.settings.YtestPickler.value then force() | |||
There was a problem hiding this comment.
Can we make this a Config option? That way it is easier to find where things should be turned on.
This disables #9619 as it lead to CI failures.
smarter
force-pushed
the
revert-9619-parallel-position-pickler
branch
from
75360b1 to
b62d712
Compare
smarter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables #9619 as it lead to CI failures.