Skip to content

Commit 75360b1

Browse files
committed
Disable "Parallelize position pickling"
This disables #9619 as it lead to CI failures.
1 parent 0246f72 commit 75360b1

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

compiler/src/dotty/tools/dotc/transform/Pickler.scala

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,17 @@ class Pickler extends Phase {
8686
pickled
8787
}(using ExecutionContext.global)
8888
def force(): Array[Byte] = Await.result(pickledF, Duration.Inf)
89-
if ctx.settings.YtestPickler.value then force()
89+
90+
// Turn off parallelism because it leads to non-deterministic CI failures:
91+
// - https://github.com/lampepfl/dotty/runs/1029579877?check_suite_focus=true#step:10:967
92+
// - https://github.com/lampepfl/dotty/runs/1027582846?check_suite_focus=true#step:10:564
93+
//
94+
// Turning off parallelism in -Ytest-pickler and Interactive mode seems to
95+
// work around the problem but I would prefer to not enable this at all
96+
// until the root cause of the issue is understood since it might manifest
97+
// itself in other situations too.
98+
force()
99+
90100
unit.pickled += (cls -> force)
91101
}
92102
}

0 commit comments

Comments
 (0)