Skip to content

URI encode semanticdb TextDocument uri #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

URI encode semanticdb TextDocument uri #9365

merged 1 commit into from
Jul 27, 2020

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha requested a review from smarter July 14, 2020 14:35
tgodzik
tgodzik approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

smarter
smarter reviewed Jul 14, 2020
View reviewed changes
smarter
smarter approved these changes Jul 14, 2020
View reviewed changes
@bishabosha bishabosha force-pushed the fix-#9281 branch 2 times, most recently from 0ef2def to b36071f Compare July 27, 2020 09:27
@bishabosha bishabosha requested a review from smarter July 27, 2020 09:29
@bishabosha bishabosha assigned smarter and unassigned bishabosha Jul 27, 2020
@bishabosha bishabosha merged commit 624cb69 into scala:master Jul 27, 2020
@bishabosha bishabosha deleted the fix-#9281 branch July 27, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
area:semanticdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

semanticDB TextDocument.uri needs to be URI encoded
3 participants
@bishabosha @smarter @tgodzik