-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Implement Tasty Pickling Independent of the Compiler #7659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test performance please |
performance test scheduled: 3 job(s) in queue, 1 running. |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/7659/ to see the changes. Benchmarks is based on merging with master (3cc436a) |
test performance please |
performance test scheduled: 2 job(s) in queue, 1 running. |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/7659/ to see the changes. Benchmarks is based on merging with master (3cc436a) |
so the benchmark graph suggests that this technique had no impact on performance. However the interface is too rigid |
c35a9e5
to
f89c505
Compare
f89c505
to
a44086c
Compare
a44086c
to
e2824b0
Compare
I am closing this due to all the changes to TASTy that would need updating. Takeaways:
|
based on #7616
Draft because currently this uses dotty syntax - which would need to be fixed if tasty-core must cross-compile with scala 2, however hopefully we can benchmark the changes.
I also intend that more things can be abstracted behind the
Tasty
interface to make its footprint smaller, but for now as few changes as possible were made to the original code