Skip to content

Independent tasty-core library #7616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 2, 2019
Merged

Independent tasty-core library #7616

merged 8 commits into from
Dec 2, 2019

Conversation

bishabosha
Copy link
Member

No description provided.

@bishabosha bishabosha requested a review from smarter November 25, 2019 23:20
@bishabosha
Copy link
Member Author

I assume we don't actually need bootstrapped/nonbootstrapped variants?

@smarter
Copy link
Member

smarter commented Nov 25, 2019

If this is to be distributed with the compiler we do actually.

smarter
smarter reviewed Nov 25, 2019
View reviewed changes
@bishabosha bishabosha requested a review from smarter November 26, 2019 13:16
@bishabosha bishabosha mentioned this pull request Nov 26, 2019
Closed
@bishabosha
Copy link
Member Author

bishabosha commented Nov 26, 2019 •
edited
Loading

I can't tell if this is passing due to os-lib failing - fixed

@bishabosha
Copy link
Member Author

@smarter is this ok to go?

@bishabosha
Copy link
Member Author

Actually I would need help cross building this to Scala 2

smarter
smarter reviewed Nov 29, 2019
View reviewed changes
@bishabosha bishabosha force-pushed the independent-tasty-lib branch from bea49a7 to 5cc877a Compare November 29, 2019 12:40
@bishabosha bishabosha requested a review from smarter November 29, 2019 13:25
nicolasstucki
nicolasstucki reviewed Dec 1, 2019
View reviewed changes
@bishabosha
Copy link
Member Author

I've noticed that I haven't added this new directory to the BootstrappedOnlyCompilationTests

@bishabosha bishabosha mentioned this pull request Dec 2, 2019
Closed
@bishabosha bishabosha merged commit 738613a into scala:master Dec 2, 2019
@bishabosha bishabosha deleted the independent-tasty-lib branch December 2, 2019 12:47
@SethTisue
Copy link
Member

@bishabosha is there documentation for this?

@bishabosha
Copy link
Member Author

@bishabosha is there documentation for this?

@SethTisue currently there is only the API docs at http://dotty.epfl.ch/api/dotty/tools/tasty.html, currently its intended as a basis for forming an independent TASTy library (that defines its own algorithm for unpicking, this library only contains the bare minimum, such as comparing TASTy version numbers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki left review comments

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bishabosha @smarter @SethTisue @nicolasstucki