Enable tests that pass, move macro tests to disabled. #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala-2 lazy vals are @volatile according to Dotty conventions.
Unlike normal fields, they aren't initialised in $init method, and need to know a bit about class layout of implementation class. Luckily AugmentScala2Traits added just enough symbols to make this work.
|
@odersky, please review. |
|
@DarkDimius Try with a parameterized |
|
AFAIK I've pushed a commit that does the same on denotations. |
|
Unfortunately, Lazy flag isn't always set for the getter method inside implementation class. |
…n implementation method. Cannot rely on it. Instead use method signature.
|
LGTM |
odersky
added a commit
that referenced
this pull request
Jun 18, 2015
Enable tests that pass, move macro tests to disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #636, all commits but e2a9573 should just move files around.
Total: 40 tests enabled, 1600+ tests disabled. Macros had quite good test base.