Add @volatile to scala2 lazyvals #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to add trait setters to Scala 2 traits was wrong. This led to AbstractMethodErrors in the formerly commented out part of scala-trait.scala.
Implementations inherit all annotations on the implemented trait methods.
For the moment, we keep all annotations on getters and setters, but this could be changed.
Scala-2 lazy vals are @volatile according to Dotty conventions.
Unlike normal fields, they aren't initialised in $init method, and need to know a bit about class layout of implementation class. Luckily AugmentScala2Traits added just enough symbols to make this work.
|
@odersky please review last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @volatile to inherited lazyvals. Right now this dies in backed. Based on #635. @DarkDimius can you take this over?