Skip to content

Add check to verify output ends with a new line in REPL scripted tests #5283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2019
Merged

Add check to verify output ends with a new line in REPL scripted tests #5283

merged 1 commit into from
Jan 13, 2019

Conversation

nrjais
Copy link
Contributor

@nrjais nrjais commented Oct 17, 2018

Fixes #4494

dottybot
dottybot reviewed Oct 17, 2018
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@odersky
Copy link
Contributor

odersky commented Jan 12, 2019

@allanrenucci Any reason not to merge this?

@allanrenucci allanrenucci merged commit ce1086a into scala:master Jan 13, 2019
@allanrenucci
Copy link
Contributor

Thanks @nrjais. Sorry that I missed this PR

@nrjais nrjais deleted the test-newline branch January 14, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@allanrenucci allanrenucci Awaiting requested review from allanrenucci

Assignees

@allanrenucci allanrenucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrjais @odersky @allanrenucci @dottybot