Fix #4172: Add regression test

[nicolasstucki]

No description provided.

[smarter]

The proper way to do this kind of tests is to add them to https://github.com/lampepfl/dotty/blob/master/compiler/test/dotty/tools/backend/jvm/InlineBytecodeTests.scala

[nicolasstucki]

@smarter I tried that but it is impossible to write by hand the equivalent access to the default pareameter getter.

[smarter]

Ah, I would write a regular bytecode test that checks that the method is not called then, or maybe a décompilation test

Moved test to DottyBytecodeTests

[Blaisorblade]

Looks somewhat reasonable: all other tests use Invoke as well.

But don't we emit InvokeDynamic sometimes? Checks for the absence of calls (like this one, dontWrapArraysInJavaVarargs and noBoxingInSyntheticEquals) won't notice that. That seems fragile.

[nicolasstucki]

In this case it is a call to a final method in the same class, it will not be an invokeDynamic.

[Blaisorblade]

In this case it is a call to a final method in the same class, it will not be an invokeDynamic.

And with the commits I pushed, our tests will enforce (part of) that too 😉. Can you please review them?

[Blaisorblade]

LGTM for the original part, but pls check my changes.

[smarter]

Invokedynamic is only used for lambdas, I don't see what it's doing here

[Blaisorblade]

Invokedynamic is only used for lambdas, I don't see what it's doing here

Is that tested? It seems easier to test for InvokeDynamic than to argue that can't possibly affect the test results, that's what we test for. Anyway, I dropped my commits since you agree.