Optimize ReifyQuotes#mayChange #4261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Apr 6, 2018
| @@ -620,7 +620,8 @@ class ReifyQuotes extends MacroTransformWithImplicits with InfoTransformer { | |||
| transform(tp) | |||
| } | |||
|
|
|||
| override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean = sym.is(Macro) | |||
| override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean = | |||
| ctx.compilationUnit.containsQuotesOrSplices && sym.isTerm && sym.is(Macro) | |||
There was a problem hiding this comment.
ctx.compilationUnit.containsQuotesOrSplices will always be true. We only run this phase if it is true
https://github.com/lampepfl/dotty/pull/4261/files#diff-7b199cbe62cc044a10a26459c0f0fa46R94
There was a problem hiding this comment.
I was wrong, we do need this check.
There was a problem hiding this comment.
We could also avoid accessing the symbol
override def transform(ref: SingleDenotation)(implicit ctx: Context): SingleDenotation =
if (ctx.compilationUnit.containsQuotesOrSplices) super.transform(ref) else ref
override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean = sym.isTerm && sym.is(Macro)There was a problem hiding this comment.
Calling Denotation#symbol is just a field access, so I don't think that's worth it.
nicolasstucki
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.