Merge pull request #4261 from dotty-staging/optimize/quote-mayChange

nicolasstucki · web-flow · commit a23ae500892b · 2018-04-06T18:27:09.000+02:00
Optimize ReifyQuotes#mayChange
diff --git a/compiler/src/dotty/tools/dotc/transform/ReifyQuotes.scala b/compiler/src/dotty/tools/dotc/transform/ReifyQuotes.scala
@@ -630,7 +630,8 @@ class ReifyQuotes extends MacroTransformWithImplicits with InfoTransformer {
     transform(tp)
   }
 
-  override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean = sym.is(Macro)
+  override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean =
+    ctx.compilationUnit.containsQuotesOrSplices && sym.isTerm && sym.is(Macro)
 
   /** Returns the type of the compiled macro as a lambda: Seq[Any] => Object */
   private def macroReturnType(implicit ctx: Context): Type =

Original file line number	Diff line number	Diff line change
`@@ -630,7 +630,8 @@ class ReifyQuotes extends MacroTransformWithImplicits with InfoTransformer {`
`630`	`630`	`transform(tp)`
`631`	`631`	`}`
`632`	`632`
`633`		`- override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean = sym.is(Macro)`
	`633`	`+ override protected def mayChange(sym: Symbol)(implicit ctx: Context): Boolean =`
	`634`	`+ ctx.compilationUnit.containsQuotesOrSplices && sym.isTerm && sym.is(Macro)`
`634`	`635`
`635`	`636`	`/** Returns the type of the compiled macro as a lambda: Seq[Any] => Object */`
`636`	`637`	`private def macroReturnType(implicit ctx: Context): Type =`