Fix #4006: Avoid ambiguity between SHAREDterm cases and finally #4017
Conversation
nicolasstucki
force-pushed
the
fix-#4006
branch
from
32dfd56 to
fd76449
Compare
|
Added description of the issue in #4006 |
| @@ -58,6 +58,7 @@ class CompilationTests extends ParallelTesting { | |||
| compileFile("tests/pos-special/i3323.scala", defaultOptions.and("-Xfatal-warnings")) + | |||
| compileFile("tests/pos-special/i3323b.scala", defaultOptions.and("-Xfatal-warnings")) + | |||
| compileFile("tests/pos-special/i3589-b.scala", defaultOptions.and("-Xfatal-warnings")) + | |||
| compileFile("tests/pos-special/i4006.scala", defaultOptions.and("-Ytest-pickler")) + | |||
There was a problem hiding this comment.
Why not put the test in tests/pickling?
| withLength { | ||
| pickleTree(block) | ||
| cases.foreach(pickleTree) | ||
| if (!finalizer.isEmpty) writeByte(FINALLY); pickleTreeUnlessEmpty(finalizer) |
There was a problem hiding this comment.
if (!finalizer.isEmpty) {
writeByte(FINALLY)
pickleTree(finalizer)
}There was a problem hiding this comment.
Will completely rewrite this code
nicolasstucki
force-pushed
the
fix-#4006
branch
4 times, most recently
from
9ce2e21 to
2268942
Compare
| @@ -1021,7 +1021,12 @@ class TreeUnpickler(reader: TastyReader, | |||
| val expr = ifBefore(end)(readTerm(), EmptyTree) | |||
| Return(expr, Ident(from.termRef)) | |||
| case TRY => | |||
There was a problem hiding this comment.
Maybe, also add a test with no finally to exercise this path. I found tests for try ... catch but not within inline def
allanrenucci
dismissed
their stale review
Oops, didn't mean to request changes
|
I think we should not add a new format tag. Tasty cases are a precious resource - the more we add the more people will get the impression that this is a complex format and will not work with it. I suppose we can use |
There was a problem hiding this comment.
I think we should not add a new format tag. Tasty cases are a precious resource - the more we add the more people will get the impression that this is a complex format and will not work with it.
I suppose we can use unsharedTag instead to get a robust disambiguation?
nicolasstucki
force-pushed
the
fix-#4006
branch
from
8181ab8 to
ad28c3f
Compare
nicolasstucki
dismissed
odersky’s stale review
Reimplemented fix using unsharedTag
nicolasstucki
requested review from
OlivierBlanvillain
and removed request for
smarter
No description provided.