Fix #3460: Fix semicolon insertion confusion after enum case #3730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jan 2, 2018
| @@ -2060,6 +2060,7 @@ object Parsers { | |||
| typeDefOrDcl(start, posMods(start, mods)) | |||
| case CASE => | |||
| enumCase(start, mods) | |||
| .reporting(t => i"case $t, current = ${in.show} / ${in.sepRegions}%, %") | |||
|
Also fixes #2906 |
After seeing an enum case, the Scanner thought it is in a pattern, and therefore does not do semicolon insertion on newlines. We now get it out of that mode by pretending to be passed the `=>`.
allanrenucci
force-pushed
the
fix-#3460
branch
from
e66e5bc to
40a2760
Compare
smarter
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing an enum case, the Scanner thought it is in a pattern, and
therefore does not do semicolon insertion on newlines. We now get it
out of that mode by pretending to be passed the
=>.