Disallow Phantom types in casts #2525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
disallow-casts-on-phantoms
branch
from
fc859b6 to
aea0cc9
Compare
OlivierBlanvillain
approved these changes
May 24, 2017
| import dotty.tools.dotc.ast.tpd | ||
|
|
||
|
|
||
| /** A no-op transform that checks whether the compiled sources have no Phantom types in casts */ |
There was a problem hiding this comment.
A no-op transform to ensure that the compiled sources have...
| } | ||
|
|
||
| private def checkNoPhantoms(tpTree: tpd.Tree)(implicit ctx: Context): Unit = { | ||
| val checker = new TypeMap { |
There was a problem hiding this comment.
What not a TypeTraverser?
There was a problem hiding this comment.
Em... will change it.
DarkDimius
reviewed
May 24, 2017
| /** A no-op transform that checks whether the compiled sources have no Phantom types in casts */ | ||
| class CheckPhantomCast extends MiniPhaseTransform { thisTransformer => | ||
|
|
||
| override def phaseName = "checkPhantomCast" |
There was a problem hiding this comment.
add a post-condition that those casts don't reappear so that Ycheck will enforce it?
nicolasstucki
force-pushed
the
disallow-casts-on-phantoms
branch
from
aea0cc9 to
4b5bd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.